First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 117261
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Python Gentoo Team <python@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Karol Pasternak (RETIRED) <reb@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
python-2.4-gentoo_obsd_configurein.patch patch for configure.in patch Karol Pasternak (RETIRED) 2005-12-31 03:30 0000 1.73 KB Details | Diff
python-2.4-gentoo_obsd_makefileprein.patch Patch for Makefile.pre.in patch Karol Pasternak (RETIRED) 2005-12-31 03:30 0000 1.42 KB Details | Diff
python-2.4-gentoo_obsd_pythonh.patch Patch for Include/Python.h patch Karol Pasternak (RETIRED) 2005-12-31 03:32 0000 262 bytes Details | Diff
python-2.4-gentoo_obsd.patch More flexible patch patch Karol Pasternak (RETIRED) 2005-12-31 06:28 0000 2.38 KB Details | Diff
python-2.4-gentoo_obsd.patch Final version of patch, i hope:> patch Karol Pasternak (RETIRED) 2006-01-03 00:06 0000 1.52 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 117261 depends on: Show dependency tree
Bug 117261 blocks: 130140
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-12-31 03:29 0000 
Python doesn't compiling on Gentoo/OpenBSD. Conditional patches for openbsd are
required.

------- Comment #1 From Karol Pasternak (RETIRED) 2005-12-31 03:30:28 0000 ------- 
Created an attachment (id=75856) [details]
patch for configure.in

------- Comment #2 From Karol Pasternak (RETIRED) 2005-12-31 03:30:53 0000 ------- 
Created an attachment (id=75857) [details]
Patch for Makefile.pre.in

------- Comment #3 From Karol Pasternak (RETIRED) 2005-12-31 03:32:12 0000 ------- 
Created an attachment (id=75858) [details]
Patch for Include/Python.h

------- Comment #4 From Diego E. 'Flameeyes' Pettenò 2005-12-31 03:50:22 0000 ------- 
No conditional patching will be allowed for anything but toolchain packages
(gcc/binutils, and only because they are way too complex).

Please rework the patches in a single portable patch. The Makefile.pre.in can
probably be ignored, as it just changes the way the library is named, and we
don't really care to maintain the same naming as the original distribution
rather than the one provided by the package itself (and also, the linux naming
on other elf operating systems make sense, for Gentoo/FreeBSD we were able to
get rid of one big problems they had: the need to recompile everything linking
to something at every bump).

The Include/Python.h is probably fine, the configure.in needs a bit of work in
the last part, have to check $host_os to use -pthread on OpenBSD and the check
for the rest of the systems.

------- Comment #5 From Karol Pasternak (RETIRED) 2005-12-31 06:28:55 0000 ------- 
Created an attachment (id=75867) [details]
More flexible patch

ok, i write more flexible patch for python this time... 
It can be used with another patches.
Tested under linux and obsd.

------- Comment #6 From Diego E. 'Flameeyes' Pettenò 2005-12-31 06:56:04 0000 ------- 
We're not yet there.
The conditional on sys/types.h is not needed, just include it, should be safe
everywhere.

uname is _not_ safe in configure to use, use the $host_os variable to check
that (and you miss a fi).

the check for OpenBSD moved out of FreeBSD is really needed? Consider that
we're going to support only ELF target and not 0/1/2 major versions, try to
limit the changes if possible.

------- Comment #7 From Karol Pasternak (RETIRED) 2006-01-03 00:06:10 0000 ------- 
Created an attachment (id=76049) [details]
Final version of patch, i hope:>

------- Comment #8 From Diego E. 'Flameeyes' Pettenò 2006-01-03 00:16:45 0000 ------- 
Yeah that's fine :)
Moving to python herd then.

Also, submit it upstream, they'll be probably be happy to apply it.

------- Comment #9 From Bryan Østergaard (RETIRED) 2006-04-14 05:56:07 0000 ------- 
Added to python-2.4.2-r1 and 2.4.3.

------- Comment #10 From Karol Pasternak (RETIRED) 2006-04-26 10:24:13 0000 ------- 
reopening bug [depend on #130140]

kloeri or anyone from python herd, can you remove old patch for Gentoo/OpenBSD
(you know why) and add this one:
http://dev.gentoo.org/~reb/obsd/patches/python-2.4-gentoo_obsd.patch ?
(with added __OpenBSD__ macro for including header)

Now gnome-python compiles fine
>>> dev-python/gnome-python-2.12.3 merged. :)

Karol

------- Comment #11 From Phil Richards 2006-04-29 05:07:49 0000 ------- 
Can somebody *please* release this new patch?  It fixes Bug #130140 (been open
for just about 2 weeks now) - this is something that is breaking gnome-python
on Linux ~x86 and has a knock-on effect for GNOME 2.14.

------- Comment #12 From James 2006-05-01 07:04:39 0000 ------- 
anyone out there want to submit this patch upstream

------- Comment #13 From Bryan Østergaard (RETIRED) 2006-05-04 07:41:54 0000 ------- 
Fixed patch in cvs now as python-2.4.2-r2 and python-2.4.3-r1.
First Last Prev Next    No search results available      Search page      Enter new bug