110420 – fix for off-by-one error in sysvinit sysproctitle

Bug 110420 - fix for off-by-one error in sysvinit sysproctitle

Summary: fix for off-by-one error in sysvinit sysproctitle

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] baselayout (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-10-25 02:39 UTC by Kir Kolyshkin
Modified:	2005-10-27 19:14 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Fixes off-by-one bug in setproctitle (sysvinit-setproctitle.patch,285 bytes, patch) 2005-10-25 02:40 UTC, Kir Kolyshkin	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kir Kolyshkin 2005-10-25 02:39:05 UTC

sysvinit-2.86 code contains a classic off-by-one bug in setproctitle() function
which leads to init process shown as 'ini' inside a VPS (OpenVZ VPS).

I will attach a one-liner patch that fixes it.

More details are in the OpenVZ bug: http://bugzilla.openvz.org/60

Comment 1 Kir Kolyshkin 2005-10-25 02:40:41 UTC

Created attachment 71383 [details, diff]
Fixes off-by-one bug in setproctitle

Comment 2 Kir Kolyshkin 2005-10-25 02:52:29 UTC

I understand that this is mainstream issue and sent a report with a patch to
sysvinit maintainer (Miquel van Smoorenburg). Still I believe that it will take
a long time to fix it mainstream so makes sense to add the patch to ebuild in
the meantime.

Comment 3 SpanKY gentoo-dev

2005-10-27 19:14:30 UTC

added to 2.86-r2, thanks for the bug

please post any updates you hear from upstream