Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 107435 - ebuild for automake-1.9.6 with new patch
Summary: ebuild for automake-1.9.6 with new patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-27 12:32 UTC by John Ratliff
Modified: 2005-09-29 01:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix automake behaviour (automake-1.9.6-suffix-rules.patch,895 bytes, patch)
2005-09-27 12:33 UTC, John Ratliff
Details | Diff
new ebuild with the patch (automake-1.9.6-r1.ebuild,1.35 KB, text/plain)
2005-09-27 12:34 UTC, John Ratliff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Ratliff 2005-09-27 12:32:53 UTC
automake has a bug where suffix rules aren't applied on a directory level correctly.

For example:

if WINDOWS
mpg_SOURCES += res/windows.rc
endif

.rc.o:
        windres @WX_INCLUDES@ -o $@ $<

Assuming you were on Windows (and don't let that throw you, it's just an
example, the program occurs on Linux, too), it will compile and put the
windows.o file in the res directory properly, but when linking, it will look for
windows.o, not res/windows.o like it should.

Discussions on the automake list produced a patch for CVS automake, which I
converted to automake 1.9.6. I'm hoping we can add this patch to the portage ebuild.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 John Ratliff 2005-09-27 12:33:38 UTC
Created attachment 69369 [details, diff]
patch to fix automake behaviour
Comment 2 John Ratliff 2005-09-27 12:34:05 UTC
Created attachment 69370 [details]
new ebuild with the patch
Comment 3 John Ratliff 2005-09-27 12:35:48 UTC
where I said 'program occurs on Linux, too, I meant 'problem'.
Comment 4 SpanKY gentoo-dev 2005-09-27 12:38:26 UTC
just so we're clear ... this patch is a backport of a fix from automake cvs for
automake 1.9.6 ?
Comment 5 John Ratliff 2005-09-27 18:48:11 UTC
No. It is a patch that was created by a user on the automake mailing list. I
have no idea if he (Stepan Kasal) is part of the development team or not. This
is what he told me

"Hello,

On Tue, Sep 27, 2005 at 05:23:43AM -0500, John Ratliff wrote:
> I tested it in Linux with automake 1.9.6 and it still doesn't work.

indeed, I previously did some quick testing with rule .list-> .c, and it worked.

But for rules .foo -> .o it really doesn't work.

I wrote a patch which fixes this.  It applies to CVS version, but also to 1.9.6,
so you don't need to install the CVS versions.
Actually, I guess that you can directly patch /usr/bin/automake.

Please find the patch attached to this mail.
(I haven't ran "make check" with it, sorry.)

Does this work for you?"

The patch he gave me would not patch for automake 1.9.6 because of new things in
 automake CVS HEAD. So I put his changes (derived from his patch) into automake
1.9.6 and created the patch I submitted against automake 1.9.6.

Originally, he wanted to know if I could test it in automake CVS, which is how
that got into the discussion. But no, this is a patch for automake 1.9.6. that
would also happen to be applicable to automake CVS.

I hope he will send his patch upstream, but until (and if) he does, the patch
only exists on the mailing list, and then the one I submitted here.
Comment 6 SpanKY gentoo-dev 2005-09-27 18:54:29 UTC
well, if it's on the automake devel list, that is upstream :)

can you provide URL's for the relevant discussions please ?
Comment 8 SpanKY gentoo-dev 2005-09-29 01:48:16 UTC
in 1.9.6-r1