Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
Not eligible to see or edit group visibility for this bug.
View Bug Activity | Format For Printing | XML | Clone This Bug
LPROF is now a sourceforge project and the project team has just released a new verion. I will attach an ebuild to this report. It should run on all platforms that support QT and lcms. But the ebuild is maked amd64 and ~x86. It has been extensively tested on amd64
Created an attachment (id=66895) [details] lprof-1.10.ebuild Here is the ebuild for verion 1.10
I don't know if this belongs in the bug report or not. But the home page for the project also needs to be updated to http://lprof.sourceforge.net If this is not the correct place to report this let me know and I will open another bug report.
This ebuild doesn't even compile. You need to check the headers of liblprof to make it compile at least.
I received a report yesterday that liblprof would not compile with gcc 4. Apparently the code has C++ style comments in the C code and this was OK for gcc versions before version 4. I have been cleaning up the code since recieving the report. I have created a new release lprof-1.10.1 that has had this fixed. I have downloaded it from SourceForge and built the release without problems. I checked each file 3 times to make sure there were no C++ style comments. So I think I got everything but I have not built it with gcc 4. In any case give the new version a try it should be fine. Sorry about the problem.
Created an attachment (id=68475) [details] a modified lprof 1.10.1 ebuild I tried the 1.10 ebuild and found that it did not correctly pick up the files for installation in the 1.10.1 distribution. The attached ebuild works for me, however I am not satisfied with copying the extraneous 'Makefile's from the data dir and subdirs into /usr/share/lprof/data -- and I am lazy and unskilled in the ways of ebuilds so did not fix it. I am using gcc version 3.3.5-20050130.
*** Bug 113638 has been marked as a duplicate of this bug. ***
I guess this headers problems is mentioned in comment #3 and i present also in the current ebuild: >>> checksums files ;-) lprof-1.09.ebuild >>> checksums files ;-) files/lprof-1.09_fix-include.patch >>> checksums files ;-) files/lprof-1.09_mrr_patch4.patch >>> checksums files ;-) files/digest-lprof-1.09 >>> checksums src_uri ;-) lprof-1.09.tar.gz >>> Unpacking source... >>> Unpacking lprof-1.09.tar.gz to /var/tmp/portage/lprof-1.09/work * Applying lprof-1.09_mrr_patch4.patch ... [ ok ] * Applying lprof-1.09_fix-include.patch ... [ ok ] >>> Source unpacked. >>> Compiling source in /var/tmp/portage/lprof-1.09/work/lprof-1.09 ... make[1]: Entering directory `/var/tmp/portage/lprof-1.09/work/lprof-1.09' little cms profiler construction set 1.09 being made all. please wait ... ( cd src ; make ) make[2]: Entering directory `/var/tmp/portage/lprof-1.09/work/lprof-1.09/src' cc -g -O4 -I../include -I../../lcms-1.09/include -fomit-frame-pointer -Wall -c cmshull.c In file included from cmshull.c:38: ../include/lcmsprf.h:39:23: lcms/lcms.h: No such file or directory [cut] The modified lprof 1.10.1 ebuild works fine for me with gcc-3.4.5 on ~x86.
LPROF has been releasing development snapshoots on a fairly regular basis and has released 5 of these since 1.10.1 was released. The current ebuilds aren't likely to work on versions after 1.10.1 since the project now uses scons to handle configuration and building.
So - can we have a working ebuild please?
Created an attachment (id=79176) [details] lprof-1.11.2.ebuild Attached is an ebuild for lprof-1.11.2. It worked on my system and is marked amd64, x86, ~ppc and ~sparc. I have never written an ebuild before so your YMMV. But it does work on my amd64 machine.
I have a few problems with this ebuild: First issue: D not found: >>> checksums files ;-) lprof-1.11.2.ebuild >>> checksums files ;-) files/digest-lprof-1.11.2 >>> checksums src_uri ;-) lprof-1.11.2.tar.gz >>> Unpacking source... >>> Unpacking lprof-1.11.2.tar.gz to /var/tmp/portage/lprof-1.11.2/work >>> Source unpacked. >>> Compiling source in /var/tmp/portage/lprof-1.11.2/work/lprof-1.11.2 ... /usr/local/portage/media-gfx/lprof/lprof-1.11.2.ebuild: line 23: D: command not found Second issue: still a header issue. Anyone an idea how to solve this one? Checking for C header file lcms.h... no You need lcms header files to compile lprof. Exit code 1
Try changing: >=media-libs/lcms-1.12 to >=media-libs/lcms-1.14 The header files in LCMS were moved to a different location I think starting with 1.13-r2 but you might as well install 1.14. Having the newer version should fix the problem with finding the LCMS header files. Give that try and see how much it helps. This may be enough to take care of everything. Please post back here with your results.
Created an attachment (id=80270) [details] modified lprof-1.11.2.ebuild
(From update of attachment 80270 [details]) Changes I made: - >=media-libs/lcms-1.13-r2 - corrected a typo in PREFIX=${D}/usr - ~x86 ~amd64, since it depends on vigra, and all the versions of vigra in portage are masked. It emerged fine here on x86 gcc3.4 :)
Created an attachment (id=80394) [details] lprof-1.11.3 ebuild Version bump. LPROF 1.11.3 has been released.
Created an attachment (id=80444) [details] ebuild for version 1.11.3.1 New ebuild for version 1.11.3.1
Apart from seeing this: install: cannot stat `{/var/tmp/portage/lprof-1.11.3.1/work/lprof-1.11.3.1/build/linux/icc2it8,': No such file or directory install: cannot stat `/var/tmp/portage/lprof-1.11.3.1/work/lprof-1.11.3.1/build/linux/lprof}': No such file or directory the build of vigra 1.3.2 and lprof 1.11.3.1 went fine, installed fine, seems to run ok.
Would be nice if we could get an official release of ebuild for version 1.11.3.1 in portage. One problem is that it will not build with gcc-4.1.0 but I can't bug it because it doesn't exist.
Could you give me details as to why it will not build with gcc 4.1. Perhaps this can be fixed in the next release which should be out in the next few weeks. The best way to do this would be to open a bug report in the Bugs tracker on the lprof sourceforge page http://sourceforge.net/tracker/?atid=764370&group_id=146038&func=browse unless you think this is a gcc bug. Also I agree that the offical version in portage needs to be updated since at this point it is very out of date and the latest releases are significantly different both with repest to the UI and the underlaying fuctionality. Also the home page that is linked when you bring this app up in the online package database to is no longer correct and needs to be updated. Is there a dev that supports this app? If so please feel free to contact me as I will do whatever is needed to get this up to date.
I get this with gcc-4.1.0: ------------------------------------------ g++ -o build/linux/checkerqt/qtcietonge.o -c -O2 -Wall -pipe -I/usr/include -I/usr/pkg/include -Isrc/libqtlcmswidgets -Isrc -Isrc/liblprof -Isrc/lprofqt -Isrc/checkerqt -Isrc/gammaqt -Isrc/IDqt -Isrc/monqt -Isrc/parmsqt -Isrc/reference_inst_qt -Ibuild/linux/libqtlcmswidgets -Isrc/libqtlcmswidgets -Ibuild/linux/liblprof -Isrc/liblprof -Ibuild/linux/lprofqt -Isrc/lprofqt -Ibuild/linux/checkerqt -Isrc/checkerqt -Ibuild/linux/gammaqt -Isrc/gammaqt -Ibuild/linux/IDqt -Isrc/IDqt -Ibuild/linux/monqt -Isrc/monqt -Ibuild/linux/parmsqt -Isrc/parmsqt -Ibuild/linux/reference_inst_qt -Isrc/reference_inst_qt -Ibuild/linux/argyll/rspl -Isrc/argyll/rspl -Ibuild/linux/argyll/numlib -Isrc/argyll/numlib -Ibuild/linux/argyll/h -Isrc/argyll/h -I/usr/qt/3/include -I/usr/qt/3/include src/checkerqt/qtcietonge.cpp /usr/qt/3/include/qnetworkprotocol.h:58: warning: 'class QNetworkProtocolFactoryBase' has virtual functions but non-virtual destructor /usr/qt/3/include/qfiledialog.h:78: warning: 'class QFilePreview' has virtual functions but non-virtual destructor /usr/qt/3/include/qtooltip.h:86: warning: 'class QToolTip' has virtual functions but non-virtual destructor src/lprofqt/lprofmain.h:402: error: extra qualification 'lprofMain::' on member 'OutputFileNameChangedMon' src/checkerqt/profilechecker.cpp:207: warning: 'void ScaleToWhite(cmsCIEXYZ*, cmsCIEXYZ*)' defined but not used scons: *** [build/linux/checkerqt/profilechecker.o] Error 1 /usr/qt/3/include/qnetworkprotocol.h:58: warning: 'class QNetworkProtocolFactoryBase' has virtual functions but non-virtual destructor /usr/qt/3/include/qfiledialog.h:78: warning: 'class QFilePreview' has virtual functions but non-virtual destructor scons: building terminated because of errors. ------------------------------------------ Also note that the errors in comment 17 apply when I build it with gcc-3.4.5. Although it does install.
This seems to be on Qt's side?
>This seems to be on Qt's side? Maybe. I'm not a programmer. Just know that it installs with gcc-3.4.5, but not with gcc-4.1.0. Qt was compiled with gcc-4.1.0.
No it was not a QT issue. All of the messages related to QT were warnings. It was basicly a typo in lprofmain.h that gcc 3.4 did not mind but gcc 4.1 being stricter would issue an error. It is now fixed in CVS and will be in the next release. If you want to fix it in src/lprofqt/lprofmain.h change virtual void lprofMain::OutputFileNameChangedMon(); to virtual void OutputFileNameChangedMon(); and it should be fine with gcc 4.1
>It is now fixed in CVS and will be in the next release. Great. Thanks! Now if we could only track down the cause of the comment #17 errors.
Created an attachment (id=81653) [details] patch per comment #23 for failure to compile with gcc-4.1 save in FILESDIR as lprof-1.11.3.1_gcc4.1fix.patch
Created an attachment (id=81654) [details] patch to the 1.11.3.1 ebuild Patches the ebuild to apply the gcc-4.1 fix plus eliminates the comment #17 error.
(In reply to comment #12) > Try changing: > > >=media-libs/lcms-1.12 > > to > > >=media-libs/lcms-1.14 > > The header files in LCMS were moved to a different location I think starting > with 1.13-r2 but you might as well install 1.14. Having the newer version > should fix the problem with finding the LCMS header files. > > Give that try and see how much it helps. This may be enough to take care of > everything. Please post back here with your results. > Yes, it is working now (sorry for my late reply). Also 1.11.3.1 emerged without any issues on my x86 p3 and p4 (gcc3.4.5 and gcc3.3.6)
Created an attachment (id=83702) [details] lprof-1.11.3.1.ebuild I had a look at this but I am currently not able to build this because of: build/linux/lprofqt/uic_lprofmainbase.cc:36:25: error: it8selector.h: No such file or directory build/linux/lprofqt/uic_lprofmainbase.cc:37:29: error: it8fileselector.h: No such file or directory build/linux/lprofqt/uic_lprofmainbase.cc:38:32: error: iccprofileselector.h: No such file or directory Anyone else seeing this or is it just my broken system?
These errors are caused by a bug in QT versions 3.3.5 and 3.3.6 with with how uic generates code related to custom widgets (which most applications don't use but lprof does). CVS now contains a work around for this problem. The easy fix is to create empty header files for the names it is looking for and placing these where they will be found. I would put these in src/liblcmswidgets. Version 1.11.4 should be out in the next few weeks and it will build with these versions of QT out of the box. Also the lprof README file documents the problem. So if all else fails read the documentation.
I am adding a bug with an LPROF 1.11.3.1 ebuild. It has a patch for the qt 3.3.5 include problem.
please, use this bug. No new bugs for the same issue
Created an attachment (id=84855) [details] lprof 1.11.3.1 ebuild w/includefix patch Oops! Sorry. I don't have the gcc4 patch in mine, I guess this ebuild should be merged with mine. I am attaching it.
Created an attachment (id=84856) [details] lprof 1.11.3.1 ebuild includehint patch fixes compilation issue
(From update of attachment 84855 [details]) # Copyright 1999-2005 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: /var/cvsroot/gentoo-x86/media-gfx/lprof/lprof-1.09.ebuild,v 1.7 2005/08/27 16:49:13 lanius Exp $ inherit eutils DESCRIPTION="Little CMS ICC profile construction set" HOMEPAGE="http://www.littlecms.com/profilers.htm" SRC_URI="http://easynews.dl.sourceforge.net/sourceforge/${PN}/${P}.tar.gz" LICENSE="GPL-2" SLOT="0" KEYWORDS="~amd64 ~x86" IUSE="" DEPEND="=x11-libs/qt-3* >=media-libs/lcms-1.12 >=media-libs/vigra-1.3.2" src_unpack() { unpack ${A} epatch ${FILESDIR}/${P}-noincludehint.patch # epatch ${FILESDIR}/${P}_mrr_patch4.patch # epatch ${FILESDIR}/${P}_fix-include.patch } src_compile() { #addpredict ${QTDIR}/etc/settings #emake || die mkdir -p ${D}/usr/ python scons.py PREFIX=${D}/usr/ } src_install() { mkdir -p ${D}/usr/ python scons.py install #dodoc README KNOWN_BUGS COPYING README.NetBSD #exeinto /usr/bin #doexe {icc2it8,qtmeasurementtool,qtmonitorprofiler,qtprofilechecker,qtscannerprofiler} #dodir /usr/share/lprof #cp -pPR ${S}/{pics,profiles,targets,template} ${D}/usr/share/lprof }
Created an attachment (id=84857) [details] lprof 1.11.3.1 ebuild w/includefix patch (correct file) Sorry!! I attached the patch as the ebuild. Here is the right ebuild.
*** Bug 130285 has been marked as a duplicate of this bug. ***
thanks, fixed
The correct home page is now http://lprof.sourceforge.net/ This has been the correct home page since Aug 2005. In addition the version of the ebuild in the portage tree is still 1.09. So the orginal reason this bug was opened has not been fixed since it was a version bump bug.
Dude, when I fix bugs, they are really fixed. And the ebuild in portage is my own version including the last fix. Just wait one hour before syncing, please.
Sorry, I looked in the online package DB and didn't find it. Should have waited a little before concluding that portage had not been updated.
*** Bug 182943 has been marked as a duplicate of this bug. ***
