Bug 9909 - fluxbox-0.1.12-r2 fails if -nls is present in use variables
Bug#: 9909 Product:  Gentoo Linux Version: 1.4_rc1 Platform: x86
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P3
Resolution: FIXED Assigned To: mkeadle@gmail.com Reported By: jrollins@charged-web.com
Component: Ebuilds
URL: 
Summary: fluxbox-0.1.12-r2 fails if -nls is present in use variables
Keywords:  
Status Whiteboard: 
Opened: 2002-10-29 12:26 0000
Description:   Opened: 2002-10-29 12:26 0000 
The remember patch provided on the fluxbox.org page states it will fail if nls
is disabled - check for this in the use variables?

------- Comment #1 From Jeff Rollins 2002-10-29 12:44:12 0000 ------- 
Created an attachment (id=5181) [details]
Revised ebuild

I think this oughta fix it - worked for me.  Someone else want to test?

------- Comment #2 From Matt Keadle 2002-10-30 01:08:45 0000 ------- 
See, here's the thing. The only difference between -r2 and -r1 is the remember
patch. So removing the remeber patch leaves no reason to go to an -r2.
Implementing the `use nls &&` works fine, but if that step is skipped you're
left with no reason to run -r2. *This* is why it is ~ keyworded, and not put
forward as  a stable build. I'm aware of the issues with the patch and nls, and
honestly I'm still trying to work out the best way to deal with it.

I've thought of adding something like:

if [ -n "`use nls`" ]
then
    ewarn "You currently have -nls in your USE. This build of Fluxbox will not"
    ewarn "build if nls is disabled."
    exit 1
fi

------- Comment #3 From Matt Keadle 2002-10-30 01:10:50 0000 ------- 
Also.. *PLEASE* when including a text attatchment remember to set the type as
'text/plain'.

------- Comment #4 From Jeff Rollins 2002-10-30 10:43:14 0000 ------- 
Sorry about that, I'm kinda new at this.  I understand completely about the
whole r2 thing - I had forgotten that i had put ~x86 in my make.conf.  Thanks
for checking into it - I'm sure whatever solution you come up with will work
fine.  Sorry for the confusion.

------- Comment #5 From Kurt Hindenburg 2002-11-01 00:15:53 0000 ------- 
Yea, I would go with the the test below; that way people have an idea what's
up.

if [ -n "`use nls`" ]
then
    ewarn "You currently have -nls in your USE. This build of Fluxbox will not"
    ewarn "build if nls is disabled."
    exit 1
fi

Kinda odd that the remember patch requires nls.  I wonder if this a
bug/misfeature in the remember patch.

USE="nls" emerge fluxbox
works fine with 0.1.12-r2

------- Comment #6 From Matt Keadle 2002-11-04 16:44:51 0000 ------- 
I've added the `if [ ! "`use nls`" ]` test to the existing -r2 ebuild. It
directs the user to run `USE="nls" emerge fluxbox` if the test fails. This build
is still ~ keyworded and not released to general population.

------- Comment #7 From Matt Keadle 2002-11-07 15:28:01 0000 ------- 
I think this package is best left as "unstable", IE ~keyworded permanantly. I'm
hearing rumors that Fluxbox 0.1.13 will have AA text and generally be overall
neat. This remember patch is nice, but the nls thing coupled with rare crashes
just won't make it into stable. I'm setting this to FIXED. I've you've got any
issues with the 0.1.12-r2 release, consider running Fluxbox without the remember
patch, waiting for 0.1.13, or dealing with the remember patch through other means.

Cheers, and thanks for the help guys!