Bug 96936 - Ebuild change: shttpd (new version, change in packagement)
Bug#: 96936 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: www-servers@gentoo.org Reported By: lzap@seznam.cz
Component: Ebuilds
URL: 
Summary: Ebuild change: shttpd (new version, change in packagement)
Keywords:  
Status Whiteboard: 
Opened: 2005-06-24 03:52 0000
Description:   Opened: 2005-06-24 03:52 0000 
I have created new version of the ebuild, that compiles versions >= 1.24
because 
the author of this small webserver changed the package (no he uses tarball 
instead of single .c file).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




I am including patches for ebuild, xinetd config, init.d config and the new 
configuration file (shttpd now uses /etc/shttpd/shttpd.conf file).

Including also already-patched versions for those who do not like patches :-)

------- Comment #1 From lzap 2005-06-24 03:53:42 0000 ------- 
Its a www-servers/shttpd.

------- Comment #2 From lzap 2005-06-24 03:55:03 0000 ------- 
Created an attachment (id=61831) [details]
ebuild 1.21 --> 1.25 diff

------- Comment #3 From lzap 2005-06-24 03:55:36 0000 ------- 
Created an attachment (id=61832) [details]
files/shttpd.conf patch to v1.25

------- Comment #4 From lzap 2005-06-24 03:56:44 0000 ------- 
Created an attachment (id=61833) [details]
files/shttpd.confd patch to v1.25

confd (not conf) - sorry, because there is also "conf" file

------- Comment #5 From lzap 2005-06-24 03:57:03 0000 ------- 
Created an attachment (id=61834) [details]
files/shttpd.xinetd patch to v1.25

------- Comment #6 From lzap 2005-06-24 03:57:44 0000 ------- 
Created an attachment (id=61835) [details]
shttpd now uses config file, this is gentoo-ready config

files/shttpd.conf

------- Comment #7 From lzap 2005-06-24 03:58:49 0000 ------- 
Created an attachment (id=61836) [details]
Patched version 1.25 (if you do not like patch :-)

------- Comment #8 From lzap 2005-06-24 03:59:05 0000 ------- 
Created an attachment (id=61837) [details]
Patched version 1.25 (if you do not like patch :-)

------- Comment #9 From lzap 2005-06-24 03:59:22 0000 ------- 
Created an attachment (id=61838) [details]
Patched version 1.25 (if you do not like patch :-)

------- Comment #10 From lzap 2005-06-24 04:01:23 0000 ------- 
I am not sure about braking lines in ebuilds with "\".

It works but there are much useless whitespace - please fix it.

  opts="-DCONFIG=\"/etc/shttpd/shttpd.conf\" \
                        -DWITH_SSL ${PN}.c -o ${PN} -lcrypto -lssl"

------- Comment #11 From Aaron Walker (RETIRED) 2005-06-27 18:46:03 0000 ------- 
Please use the unified diff format (diff -u) in the future.  No need to post
patched versions, as just the diffs will do.  This is on my todo list for
tonight at work so it should be done in the morning.

------- Comment #12 From Aaron Walker (RETIRED) 2005-06-27 18:48:54 0000 ------- 
oops and I forgot to mention.  Always use text/plain for text files (patch is
fine for patches), otherwise it's not possible to view it in the browser.

------- Comment #13 From Aaron Walker (RETIRED) 2005-06-28 06:56:20 0000 ------- 
Did you try testing it at all?

There seems to be something b0rked with the config file code.  Unless I remove
the config file, it dies every time with:

].Each line in config file must be in format '<var> <value>'

It does this regardless of config (yours or the one distributed by uptstream). 
I don't have the time now to look into it, but needless to say until I get/write
a patch or he releases a new version that fixes it, it's not going into portage.

------- Comment #14 From lzap 2005-06-28 09:49:56 0000 ------- 
Got the bug!

The conf file was created under Win32 with Windows-like linefeeds. Please fix it
using Vim or recode, thank you. Will notice the author.

------- Comment #15 From Aaron Walker (RETIRED) 2005-06-30 21:49:03 0000 ------- 
In CVS.  Thanks Lukas.