Bug 92710 - xxdiff-3.0.2 dependancy on KDE isnt handled 100% correctly
Bug#: 92710 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: kde@gentoo.org Reported By: groepaz@gmx.net
Component: Ebuilds
URL: 
Summary: xxdiff-3.0.2 dependancy on KDE isnt handled 100% correctly
Keywords:  
Status Whiteboard: 
Opened: 2005-05-15 08:54 0000
Description:   Opened: 2005-05-15 08:54 0000
i somehow ended up with a /usr/kde/3.4/share/doc/HTML/en/kompare/common/
directory (maybe another bug that should be handled seperatly?) and nothing
else of kde3.4 installed... this causes the xxdiff ebuild to think that i am
using kde3.4, and the build fails.

what i did was changing the detection to look for the /include subdirectory in
the kde tree instead of just the kde directory, resulting in it detecting the
correct version of kde.

src_unpack()
{
        unpack ${A}
        if use kde; then
                cd ${S}/src
                cp ${FILESDIR}/kdesupport.patch .
                # this one is not 100%
                #sed -e "s:/usr/kde/3.1:`ls -d /usr/kde | tail -n 1`:g" -i
kdesupport.patch
                # this one works perfectly fine
                sed -e "s:/usr/kde/3.1:`ls -d /usr/kde/*/include | sed -e
"s:/include::g" | tail -n 1`:g" -i kdesupport.patch
                epatch kdesupport.patch
        fi
}

mmmh...maybe there should be a function dedicated to this so the kde version
detection can be addressed in a centralized way?



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

------- Comment #1 From groepaz@gmx.net 2005-05-15 08:58:28 0000 -------
Created an attachment (id=58956) [details]
fixed ebuild

------- Comment #2 From Gregorio Guidi (RETIRED) 2005-05-17 08:00:45 0000 -------
The detection of kde was indeed clumsy. I changed the ebuild to properly use 
the kde eclasses in 3.0.2-r1. Thanks.