Bug 92573 - app-admin/gamin version bump to 0.1.0
Bug#: 92573 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: gnome@gentoo.org Reported By: dsd@gentoo.org
Component: GNOME
URL: 
Summary: app-admin/gamin version bump to 0.1.0
Keywords:  
Status Whiteboard: 
Opened: 2005-05-14 03:35 0000
Description:   Opened: 2005-05-14 03:35 0000
This requires inotify 0.23-6 which is not available in portage yet, so if its
added to portage, it needs to be in package.mask.

gentoo-sources-2.6.12 will include inotify 0.23-7 or whatever the newest one is
at time of release.

------- Comment #1 From Daniel Drake 2005-05-14 03:35:42 0000 -------
Created an attachment (id=58855) [details]
gamin-0.1.0.ebuild

Nothing needed changing except the info messages

------- Comment #2 From Mark Rosenstand 2005-05-15 05:34:23 0000 -------
Created an attachment (id=58948) [details]
gamin-0.1.0.ebuild (noinotify USE flag)

Optional (although heavily encouraged) inotify usage. I got it imported to
gentopia yesterday.

------- Comment #3 From Mark Rosenstand 2005-05-15 08:39:41 0000 -------
(From update of attachment 58948 [details])
Never mind. joem didn't like the idea of configurable inotify support.

------- Comment #4 From Daniel Drake 2005-05-23 13:11:03 0000 -------
Created an attachment (id=59654) [details]
gamin-0.1.0.ebuild

Latest bugfix from John McCutchan

------- Comment #5 From Daniel Drake 2005-05-23 13:11:25 0000 -------
Created an attachment (id=59655) [details]
gamin-0.1.0-flow-control.patch

The actual fix

------- Comment #6 From Giacomo Perale 2005-05-23 14:38:03 0000 -------
Created an attachment (id=59663) [details]
gamin-0.1.0-cvs-upgrade.patch

includes two CVS fixes since the release of 0.1.0

* server/gam_poll.c: (unregister_node), factorize code and make sure node are
unregistered correctly. Fix crash from bug #303932.
* libgamin/gam_data.c: (gamin_data_conn_event): Fix req->state vs req->type
thinko.

------- Comment #7 From Steev Klimaszewski 2005-05-23 14:50:51 0000 -------
Is this going to go into the gentopia overlay as well?

------- Comment #8 From Doug Goldstein 2005-05-23 19:51:37 0000 -------
Dan, any chance we can give ya commit access or anything? And you toss them in
there? It will give you a larger test base.

------- Comment #9 From Doug Goldstein 2005-05-23 19:56:30 0000 -------
Dan, to Gentopia that is.

Added ebuild to Gentopia overlay as gamin-0.1.0-r1.ebuild with both patches applied.

------- Comment #10 From Diego E. 'Flameeyes' Pettenò 2005-05-26 16:07:28 0000 -------
fam is not going to work fine on Gentoo/FreeBSD, I'll submit a patch to this 
ebuild and a patch to gamin sourced (cumulative of ports patches) as gamin is 
probably the best way to go for us. 

------- Comment #11 From Diego E. 'Flameeyes' Pettenò 2005-05-26 16:18:50 0000 -------
Created an attachment (id=59898) [details]
gamin-0.1.0-r1.patch

(svn) patch over gamin-0.1.0-r1 ebuild, which adds G/FreeBSD support.

------- Comment #12 From Diego E. 'Flameeyes' Pettenò 2005-05-26 16:19:57 0000 -------
Created an attachment (id=59899) [details]
gamin-0.1.0-freebsd.patch

Patch with all the FreeBSD changes. Works fine on Linux (and probably
Gentoo/kFreeBSD), too.

------- Comment #13 From gad.kadosh@gmail.com 2005-06-18 04:19:27 0000 -------
gamin-0.1.1 is out, but it doesn't look like kernel 2.6.12 has inotify ?

------- Comment #14 From Daniel Drake 2005-06-18 08:01:48 0000 -------
Correct. inotify has never been in the upstream kernel.

------- Comment #15 From Claessens Xavier 2005-06-18 22:03:20 0000 -------
gentoo-sources-2.6.12 is out with inotify 0.23-12. So gamin-0.1.0 can now be in
portage in ~x86

------- Comment #16 From Steev Klimaszewski 2005-06-19 01:48:11 0000 -------
I'm not sure if it works for you Claessens, however, here, I have
gentoo-sources-2.6.12, and gamin-0.1.0-r1 (and even tried gamin CVS) and I am
back to the problem that I had before with mm-sources, in which, gamin no longer
notifies/reads my usb disk insertion/pmount no longer automounts the disk.

steev@mebius ~ $ pmount-hal /org/freedesktop/Hal/devices/volume_uuid_1C98_52D7
Error: device /dev/sda1 is not removable

Is what I get (and got with mm-sources, but due to mm-sources nature, I didn't
file a bug, simply bumped down to 2.6.11-r11, which worked fine once I applied
the proper patch for inotify to the kernel)  It seems like the new inotify patch
in gentoo-sources SHOULD work, but apparently, something is missing somewhere. 
Watching both gamin and pmount closely to see.

------- Comment #17 From Daniel Drake 2005-06-19 02:10:10 0000 -------
I think you are running into a HAL bug which is fixed in hal 0.5. Either way,
it's certainly not related to gamin.

------- Comment #18 From Claessens Xavier 2005-06-19 12:27:59 0000 -------
works for me yes ! just tried gamin-0.1.0.ebuild and
gamin-0.1.0-flow-control.patch.

i've sys-apps/hal-0.4.8 and usb key are correctly monted and the icon appeare
on
the gnome desktop witch was buggy with preview versions of kernel/gamin.

------- Comment #19 From Daniel Drake 2005-06-20 10:43:26 0000 -------
gamin-0.1.1 is now included in the tree