Bug 92485 – x11-terms/eterm-0.9.3-r4 fails to build with gcc4

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Aaron Walker (RETIRED) 2005-05-13 04:50:31 UTC]

/bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include -I/usr/X11R6/include   -O2 -march=athlon-xp -pipe -c e.c
command.c: In function 'init_command':
command.c:3005: error: invalid lvalue in assignment
command.c:3007: error: invalid lvalue in assignment
command.c: In function 'main_loop':
command.c:3472: warning: pointer targets in passing argument 1 of 'safe_print_string' differ in signedness
make[2]: *** [command.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
rm -f .libs/e.lo
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include -I/usr/X11R6/include -O2 -march=athlon-xp -pipe -c e.c  -fPIC -DPIC -o .libs/e.lo
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include -I/usr/X11R6/include -O2 -march=athlon-xp -pipe -c e.c -o e.o >/dev/null 2>&1
mv -f .libs/e.lo e.lo
make[2]: Leaving directory `/buildroot/portage/eterm-0.9.3-r4/work/Eterm-0.9.3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/buildroot/portage/eterm-0.9.3-r4/work/Eterm-0.9.3'
make: *** [all-recursive-am] Error 2

Attached is a patch to build eterm w/gcc-4.  Note that only the first chunk
is actually needed for a successfull build.  The rest of that huge patch is
for the zillions of signedness warnings.  Only one signedness warning remains,
as I wasn't sure what the fix was, but it's in the deadkeys patch anyways.

Also, FYI the patch was written against the patched eterm, but still applies
to the vanilla eterm with a couple offsets.

[Comment 1 Aaron Walker (RETIRED) 2005-05-13 04:51:44 UTC]

Created attachment 58807 [details, diff]
eterm-0.9.3-gcc4.patch

[Comment 2 SpanKY 2005-05-14 11:08:03 UTC]

this has already been fixed in upstream cvs so i just added the first hunk to portage