Summary: | sys-apps/busybox: does not fully respect CFLAGS by appending -Oz after user flags | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Embedded Gentoo Team <embedded> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ceamac, esigra |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 59506 |
Description
Sam James
2023-12-15 06:45:16 UTC
It's true, but I wouldn't drop -Oz either. Most people have -O2 in CFLAGS. Maybe add a USE flag? On the other hand, people are free to add -Os/-Oz to stuff likely to be in their initramfs if they want... My hope is to avoid the USE=custom-cflags deal here as it feels kind of icky and not really well-defined for when it should be used anyway. Perhaps we could compromise with something like an einfo or ewarn on first install or upgrade from $first_version_before_fixed if not using -Oz to let users know they can do it if they want. Sounds good. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9cfecde4ffda1b5e7c9af6d3337604038663298 commit a9cfecde4ffda1b5e7c9af6d3337604038663298 Author: Viorel Munteanu <ceamac@gentoo.org> AuthorDate: 2023-12-16 10:23:14 +0000 Commit: Viorel Munteanu <ceamac@gentoo.org> CommitDate: 2023-12-16 10:25:23 +0000 sys-apps/busybox: respect CFLAGS Don't force -Oz, but add a small message the first time it's missing, in case anyone was counting on it. Closes: https://bugs.gentoo.org/919975 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org> sys-apps/busybox/busybox-1.36.1-r1.ebuild | 379 ++++++++++++++++++++++++++++++ 1 file changed, 379 insertions(+) Thank you! Sync live too? Done. Thanks! |