Gentoo Full Text Bug Listing

Description:

Opened: 2005-05-08 23:35 0000

New version of eject including a bunch of patches from ubuntu, including:
   - a new version of the finddev patch (adds documentation)
   - pumount support (for Utopia; blocks #91928) 
   - several fixes for remote situations
   - check malloc return value for NULL

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Nathaniel McCallum (RETIRED) 2005-05-08 23:37:28 0000 -------

Created an attachment (id=58442) [details]
make sure fd's are closed correctly

------- Comment #2 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:04 0000 -------

Created an attachment (id=58443) [details]
make sure DEFAULTDEVICE starts with "/dev/"

------- Comment #3 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:34 0000 -------

Created an attachment (id=58444) [details]
new version of finddev (includes documentation)

------- Comment #4 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:57 0000 -------

Created an attachment (id=58445) [details]
make sure we can read fstab

------- Comment #5 From Nathaniel McCallum (RETIRED) 2005-05-08 23:39:29 0000 -------

Created an attachment (id=58446) [details]
check the return value of malloc for NULL

------- Comment #6 From Nathaniel McCallum (RETIRED) 2005-05-08 23:39:58 0000 -------

Created an attachment (id=58447) [details]
adds a don't unmount option

------- Comment #7 From Nathaniel McCallum (RETIRED) 2005-05-08 23:40:27 0000 -------

Created an attachment (id=58448) [details]
adds pumount support (project utopia)

------- Comment #8 From Nathaniel McCallum (RETIRED) 2005-05-08 23:40:57 0000 -------

Created an attachment (id=58449) [details]
make sure we have a proper regex

------- Comment #10 From Jakub Moc (RETIRED) 2005-05-08 23:55:25 0000 -------

Would you like to have a look at Bug 62612 as well? :-)

------- Comment #11 From Nathaniel McCallum (RETIRED) 2005-05-09 00:08:18 0000 -------

sure, you can assign it to me if you like, but I'd like to put it in a revision
on its own to get more testing.  All the patches I've put here are fairly well
tested.

------- Comment #12 From SpanKY 2005-05-09 00:17:44 0000 -------

fedora has a patch or two not included here ...

------- Comment #13 From Jakub Moc (RETIRED) 2005-05-09 00:51:47 0000 -------

Comment #11: As you wish, assigned #62612 to you. If you

------- Comment #14 From Jakub Moc (RETIRED) 2005-05-09 00:51:47 0000 -------

Comment #11: As you wish, assigned #62612 to you. If you´d like to maintain
this ebuild, then you could add yourself to metadata.xml.

------- Comment #15 From SpanKY 2005-05-20 20:30:55 0000 -------

some notes ...

- the close patch is pretty stupid/pointless
- the malloc check is incomplete ... it's not the only malloc in eject.c
- the regcomp check is incomplete ... it's not the only regcomp in eject.c
- what's the point of the pumount patch ?

added all but the pumount patch to eject-2.0.13-r2 after cleaning many of them up

------- Comment #16 From Nathaniel McCallum (RETIRED) 2005-05-20 20:38:22 0000 -------

pmount (and pumount) are policy wrappers around mount for removeable devices
that aren't in fstab.  Desktop programs use eject (ie. gnome-vfs).  Lets say in
this case you plug in a usb zip drive.  gnome-vfs uses pmount to mount it, then
the user wants to eject it.  The user chooses eject in nautilus, which (through
gnome-vfs) calls eject.  When eject tries to umount the device, it will fail, so
eject will be broken.  The pumount tries at runtime to run pumount before
umount.  Nothing breaks if pumount isn't installed or fails (we don't check the
exit status).

------- Comment #17 From SpanKY 2005-05-20 22:58:44 0000 -------

added to 2.0.13-r2

Bug#: 91977	Product: Gentoo Linux	Version: unspecified	Platform: All
OS/Version: Linux	Status: RESOLVED	Severity: enhancement	Priority: P2
Resolution: FIXED	Assigned To: base-system@gentoo.org	Reported By: npmccallum@gentoo.org
Component: Applications
URL:
Summary: new version of eject
Keywords:
Status Whiteboard:
Opened: 2005-05-08 23:35 0000