Summary: | media-video/mkvtoolnix-1.4.2 - mmg segfault whenever the "add" button is pressed | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | will_luan |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chutz+bugs.gentoo.org |
Priority: | High | Keywords: | Inclusion |
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 98089 | ||
Bug Blocks: | 92499 |
Description
will_luan
2005-05-03 09:44:32 UTC
can we fix this plz? I have the same problem, but the proper fix I believe is this: --- /usr/portage/media-video/mkvtoolnix/mkvtoolnix-1.4.2-r1.ebuild 2005-06-03 19:55:45.000000000 +0900 +++ ./mkvtoolnix-1.4.2-r1.ebuild 2005-07-11 13:20:50.000000000 +0900 @@ -44,6 +44,7 @@ epatch ${FILESDIR}/${PN}-configure-checks.patch epatch ${WORKDIR}/${P}-nowarns.patch + sed -i -e "s:wx-config :${WX_CONFIG} :" configure.in ./autogen.sh } It's just that wx-config is currently hard-coded in configure.in (and configure), and it defaults to wxGTK-2.4 if 2.4 is installed. Or, it fails if 2.4 is not installed (well, it says that you don't have wx-config and skips the gui). It would also be nice to see a version bump to mkvtoolnix-1.5.0. The pkg_setup portion could be improved like this: @@ -31,7 +30,11 @@ if ! use gtk2 ; then need-wxwidgets gtk || die "You must compile wxGTK without wx_nogtk useflag." else - need-wxwidgets gtk2 || die "You must compile wxGTK with gtk2 useflag." + if use unicode; then + need-wxwidgets unicode || die "You must compile wxGTK with unicode useflag." + else + need-wxwidgets gtk2 || die "You must compile wxGTK with gtk2 useflag." + fi fi elif use gtk2; then einfo "You won't have gtk2 support as you requested not to use wxwindows." Though I have no idea how the -ansi and -unicode versions of wxGTK differ, but I have USE=unicode and it would be nice to have mmg link against the unicode version of wxGTK. 1.5.5 fixes the problem. (In reply to comment #3) > 1.5.5 fixes the problem. Please, take a look at my comment #2. The location to wx-config is hard-coded in the configure script, hence the sed. I just emerged 1.5.5 from the official portage tree, and I did not get mmg installed. I only have wxGTK 2.6.1 on my system (I don't have wxGTK 2.4). I am now emerging with the patch from comment #2 and it seems to be going fine: $ diff -u 4849-mkvtoolnix-1.5.5.log 4850-mkvtoolnix-1.5.5.log | head -n 30 --- 4849-mkvtoolnix-1.5.5.log 2005-09-05 03:42:21.000000000 +0900 +++ 4850-mkvtoolnix-1.5.5.log 2005-09-05 03:57:24.000000000 +0900 @@ -1,4 +1,5 @@ - * Using /usr/lib64/wx/config/gtk2-ansi-release-2.6 +QA Notice: USE Flag 'unicode' not in IUSE for media-video/mkvtoolnix-1.5.5 + * Using /usr/lib64/wx/config/gtk2-unicode-release-2.6 >>> Unpacking source... >>> Unpacking mkvtoolnix-1.5.5.tar.bz2 to /var/tmp/portage/mkvtoolnix-1.5.5/work >>> Source unpacked. @@ -85,7 +86,7 @@ checking bzlib.h usability... yes checking bzlib.h presence... yes checking for bzlib.h... yes -checking for wxWidgets... no: wx-config was not found +checking for wxWidgets... 2.6.1 ok configure: creating ./config.status config.status: creating Makefile config.status: creating avilib-0.6.10/Makefile @@ -102,8 +103,8 @@ config.status: creating config.h *** The mkvtoolnix configuration is complete. -*** Optional features that are built: FLAC audio (1.1.1 or newer); LZO compression; BZ2 compression -*** Optional features that are NOT built: GUIs +*** Optional features that are built: FLAC audio (1.1.1 or newer); LZO compression; BZ2 compression; GUIs +*** Optional features that are NOT built: CXX src/merge/cluster_helper.cpp src/merge/cluster_helper.cpp: In member function `void cluster_helper_c::add_packet(packet_cptr)': src/merge/cluster_helper.cpp:105: warning: long long int format, int64_t arg (arg 3) |