Bug 91096 - asciidoc-6.0.3.ebuild (new package)
|
Bug#:
91096
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: All
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P3
|
|
Resolution: FIXED
|
Assigned To: text-markup@gentoo.org
|
Reported By: brandon@ifup.org
|
|
Component: Ebuilds
|
|
|
URL:
http://ifup.org/~philips/asciidoc-6.0.3.ebuild
|
|
Summary: asciidoc-6.0.3.ebuild (new package)
|
|
Keywords: EBUILD
|
|
Status Whiteboard:
|
|
Opened: 2005-05-01 18:46 0000
|
Also, if someone can figure why fperms wouldn't work I would appreciate it.
# For some reason fperms wouldn't work with a wild card
# but it worked when ran from the command line...
chmod 664 ${D}/etc/${PN}/*.conf
chmod 664 ${D}/etc/${PN}/filters/*.conf
I ended up using chmod obviously but fperms would probably be better.
Is there anything I can do to help get this in?
Sorry for the delay. text-markup herd is out of human resources
and we are already overloaded (80 open bugs, where 20 of them
are new ebuilds). I often ask other Gentoo developers to join the
herd to solve this situation, but with little success. If you can wait
for another week or so, I'll take this in. (I can spend my time to
Gentoo only on weekend)
I checked your ebuild and modified a bit, and committed.
Here is what I changed: (you can have a look at complete
ebuild after you synched portage tree)
* `inherit eutils` isn't necessary because you used none
of the functions from that eclass.
* ${MY_P} assignment isn't necessary because ${P} is already
set to "${PN}-${PV}", where ${PN} is set to asciidoc. (in
other word, you can use ${P} rather than defining the same
thing with another name)
* No need to redefine ${S} (same reason as above)
* No need to redefine src_unpack(). Every file listed in
${SRC_URI} is set to ${A}, and automatically unpacked.
* In general, you don't need to write ${S} in src_install()
when you are in ${S}.
* We already have a copy of GPL-2 text in /usr/portage/licenses,
so don't need to copy it again.
* fperms wildcard doesn't work because wildcard is evaluated
by bash when it is called, and you are not likely to have
configuration files in /etc before you actually install it ;)
I think it's okay to use chmod in this case, but I replaced
it with `insopts -m664` and insinto/doins (we usually avoid
writing ${D} as much as possible)
Lastly, your ebuild does work and please feel encouraged to
make another ebuild ;)
Thanks for your contribution.