Bug 894700 – x11-misc/xscreensaver-6.06-r2 installs .desktop files that do not pass validation (LIBARCHIVE-SYSTEM)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-02-16 07:09:49 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/xscreensaver-6.05-r2 installs .desktop files that do not pass validation (LIBARCHIVE-SYSTEM).
Discovered on: amd64 (internal ref: libarchive_tinderbox)

NOTE:
(LIBARCHIVE-SYSTEM) in the summary means that the bug was found on a machine that runs app-alternatives/tar and app-alternatives/cpio with [-gnu,+libarchive] but this bug MAY or MAY NOT BE related to the tar/cpio implementation.

[Comment 1 Agostino Sarubbo 2023-02-16 07:09:51 UTC]

Created attachment 851526 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2023-05-18 10:56:22 UTC]

ci has reproduced this issue with version 6.06 - Updating summary.

[Comment 3 Agostino Sarubbo 2023-07-27 09:15:46 UTC]

ci has reproduced this issue with version 6.06-r1 - Updating summary.

[Comment 4 Agostino Sarubbo 2023-08-09 09:11:43 UTC]

ci has reproduced this issue with version 6.06-r2 - Updating summary.

[Comment 5 Florian Schmaus 2023-08-18 11:57:13 UTC]

> * 	/usr/share/applications/xscreensaver-settings.desktop: error: value item "Screensaver" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included
> * 	/usr/share/applications/xscreensaver.desktop: error: value item "Screensaver" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included

I am not sure if there is a sensible fix for this. We could list as many as possible desktop environments in OnlyShownIn, but this may has the side effect that xscreensver does not appear in desktop environments where xscreensaver would work.

FTR, debian also does not fix this: https://salsa.debian.org/debian/xscreensaver/-/blob/c7a84aa7c0a3d90e9204e3c6a68bffb36e482dc6/debian/patches/98_daemon_desktop_file.patch

[Comment 6 Larry the Git Cow 2023-09-06 10:51:40 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0c684e2e738b135418c214badafa93a7b02ea4c

commit b0c684e2e738b135418c214badafa93a7b02ea4c
Author:     Pascal Jäger <[e-mail]>
AuthorDate: 2023-09-05 12:29:59 +0000
Commit:     Florian Schmaus <[e-mail]>
CommitDate: 2023-09-06 10:49:20 +0000

    x11-misc/xscreensaver: add 6.07
    
    Closes: https://bugs.gentoo.org/894700
    Closes: https://bugs.gentoo.org/896440
    Closes: https://bugs.gentoo.org/908509
    Closes: https://bugs.gentoo.org/912075
    
    Signed-off-by: Pascal Jäger <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/32628
    Signed-off-by: Florian Schmaus <[e-mail]>

 x11-misc/xscreensaver/Manifest                     |   1 +
 .../files/xscreensaver-6.07-allow-no-pam.patch     |  18 ++
 .../xscreensaver-6.07-fix-desktop-files.patch      |  31 +++
 .../xscreensaver/files/xscreensaver-6.07-gcc.patch |  24 ++
 ...7-service-remove-Alias-org.jwz.xscreensav.patch |  13 +
 x11-misc/xscreensaver/xscreensaver-6.07.ebuild     | 265 +++++++++++++++++++++
 6 files changed, 352 insertions(+)