| Summary: | /etc/init.d/mpd start-stop-daemon in stop() function should specify --oknodo | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Philip Kovacs <pkdevel> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
fixed in cvs, thanks |
The mpd daemon will have terminated by the time start-stop-daemon --stop gets to it, since mpd traps the TERM signal and shuts down well before its /etc/init.d/mpd stop command is run. The start-stop-daemon --stop command in /etc/init.d/mpd will return 1 unless --oknodo is specified, as it should in this case. The fix below will cause eend $? to report [ok] on mpd shutdown and not [!!]. In /etc/init.d/mpd: stop() { ebegin "Stopping Musinc Player Daemon" start-stop-daemon --stop --quiet --exec /usr/bin/mpd eend $? } should be: stop() { ebegin "Stopping Musinc Player Daemon" start-stop-daemon --stop --quiet --exec /usr/bin/mpd --oknodo eend $? } Reproducible: Always Steps to Reproduce: 1. 2. 3.