Bug 89174 - groff fails to compile with non-bash shell due to groff-1.18-no-netpbm-depend.patch
Bug#: 89174 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: base-system@gentoo.org Reported By: haubi@gentoo.org
Component: Core system
URL: 
Summary: groff fails to compile with non-bash shell due to groff-1.18-no-netpbm-depend.patch
Keywords:  
Status Whiteboard: 
Opened: 2005-04-15 05:58 0000
Description:   Opened: 2005-04-15 05:58 0000 
If for some reason groff uses a non-bash shell {sh,ksh} for compilation,
the groff-1.18-no-netpbm-depend.patch breaks this.

Reproducible: Always
Steps to Reproduce:
1. Look at bug 87877 for the backgrounds of such a build-environment.
2. Try to install groff on a sparc-sun-solaris2.8 box with the groff-*.ebuild
3. You do not actually need to do this: there's a patch attached here.

Actual Results:  
for f in ; do \
  rm -f
/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f;
\
  /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/bin/install -c -m 644 ./$f
/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f;
\
done
/bin/ksh: syntax error at line 1 : `;' unexpected
make[2]: *** [install_data] Error 2
make[2]: Leaving directory
`/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1/doc'
make[1]: *** [doc] Error 2
make[1]: Leaving directory
`/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1'
make: *** [install] Error 2

------- Comment #1 From Michael Haubenwallner 2005-04-15 06:00:30 0000 ------- 
Created an attachment (id=56349) [details]
let groff compile with non-bash shells too

------- Comment #2 From SpanKY 2005-04-15 11:09:57 0000 ------- 
the netpbm patch is just very ugly anyways ... should rewrite it to not suck
...

------- Comment #3 From SpanKY 2005-04-15 15:35:52 0000 ------- 
changed the patch so it sets the variables to '' rather than '# ...'

------- Comment #4 From Michael Haubenwallner 2005-04-18 07:05:51 0000 ------- 
Well, the macros _are_ already empty, the '#' is seen by _make_ as a comment.

The problem is the shell-code (part 2 in my patch), where _make_ calls the shell
like this: system("/bin/sh -c 'for f in ; do ...'")

The non-bash-Shell does not accept the "for f in ; do ...", but would accept
"for f in ${list} ; do ..." where ${list} expands to empty.

------- Comment #5 From SpanKY 2005-04-26 20:47:05 0000 ------- 
*now* you tell me :P

updated the netpbm patch