Bug 885741

Summary:	app-admin/pass-otp-1.2.0-r1 fails tests (DASH-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Haelwenn (lanodan) Monnier <contact>
Status:	CONFIRMED ---
Severity:	normal	CC:	ktoupt, proxy-maint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	526268
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2022-12-13 09:36:15 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/pass-otp-1.2.0-r1 fails tests (DASH-SYSTEM).
Discovered on: amd64 (internal ref: dash_tinderbox)

Comment 1 Agostino Sarubbo gentoo-dev

2022-12-13 09:36:17 UTC

Created attachment 842373 [details]
build.log

build log and emerge --info

Comment 2 ktoupt 2024-04-03 02:56:48 UTC

I could be wrong, but I do not think this is a dash specific issue.

Here is an upstream bug from a Fedora user, which, I think, does not use
dash:

https://github.com/tadfisher/pass-otp/issues/171

The issue is with incrementing the HOTP counter in the otp.bash script.
Instead of replacing the old counter text, it appends the new text after
the old text.

It seems that the issue is missing quotes around a shell parameter
expansion, as seen from this patch:

https://github.com/tadfisher/pass-otp/pull/172