Bug 88025 - media-sound/cmus-2.0.4.ebuild (New Package)
|
Bug#:
88025
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: All
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: fauli@gentoo.org
|
Reported By: tihirvon@ee.oulu.fi
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: media-sound/cmus-2.0.4.ebuild (New Package)
|
|
Keywords: EBUILD, InOverlay
|
|
Status Whiteboard: Sunrise Overlay
|
|
Opened: 2005-04-05 05:07 0000
|
Is there a reason, that this ebuild isn't included in the main portage tree?
It's rock solid, and I know a lot of people who already use it.
Also the maintainer keeps building new ebuilds himself regularly, so it
shouldn't be a lot of work to include it.
I would like to see this ebuild in the portage tree, too.
Created an attachment (id=90838) [details]
Ebuild for cmus v2.0.3, which uses a new configuration scheme
This is a suggestion for an ebuild for cmus v2.0.3. Cmus v2.0.3 uses a new
configuration scheme, and this ebuild abides by it.
Thanks. DEBUG must be uppercase.
local DEBUG myconf
if use debug
then
DEBUG=2
else
DEBUG=1
fi
...
./configure prefix=/usr ${myconf} DEBUG=$DEBUG || die
You could use my_config() for DEBUG too. Also myconf is local and my_config()
uses global myconf variable, are you sure it works? There's no
CONFIG_MUSEPACK, it's CONFIG_MPC.
$ ./configure --help|grep CONFIG
CONFIG_FLAC FLAC (Free Lossless Audio Codec) support [auto]
CONFIG_MAD MPEG Audio Decoder (libmad) support [auto]
CONFIG_MODPLUG libmodplug (mod, x3m, ...) support [auto]
CONFIG_MPC libmpcdec (Musepack .mpc) support [auto]
CONFIG_VORBIS Ogg/Vorbis support [auto]
CONFIG_TREMOR Use Tremor as Ogg/Vorbis input plugin [n]
CONFIG_WAV WAV support [y]
CONFIG_ALSA ALSA support [auto]
CONFIG_AO Libao cross-platform audio library [auto]
CONFIG_ARTS ARTS support [auto]
CONFIG_OSS Open Sound System support [auto]
CONFIG_SUN Sun Audio support [auto]
(In reply to comment #9)
> You could use my_config() for DEBUG too.
Forget this. CONFIG_* are booleans and DEBUG is 0-2.
(In reply to comment #9)
> Thanks. DEBUG must be uppercase.
> ./configure prefix=/usr ${myconf} DEBUG=$DEBUG || die
I turned it into DEBUG=$debuglevel (which I now realize should have been
${debuglevel} to go with standard ebuild style).
> Also myconf is local and my_config() uses global myconf variable, are
> you sure it works?
Yes. It's dynamically scoped in my_config(), even if it's declared local.
This usage may seem a bit ugly, but it makes the code simple. Someone with
more ebuild experience than me might disagree (and know of a better way to do
this).
> There's no CONFIG_MUSEPACK, it's CONFIG_MPC.
Fixed.
I bumped to version 2.0.4, revised the ebuild to fit common standards, added
mp3 USE flag and submitted it to Sunrise Overlay. I will bring it to the tree
as soon as I have commit access.
This is now in the sunrise overlay. You can find it at soon:
http://gentoo-sunrise.org/svn/reviewed/media-sound/cmus
Is in Portage now, request keywords for architectures you could test. Thanks.