Summary: | net-misc/howl-0.9.6-r2 fails to build (this is not a duplicate from #87436) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeff <jesterr> |
Component: | Current packages | Assignee: | Tim Yamin (RETIRED) <plasmaroo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | han.soete, ladanyi, particle, paul, stkn |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
diff output between ethtool.h for linux-headers-2.6.8.1-r2
fixes missed typedef-s |
Description
Jeff
2005-03-31 23:13:22 UTC
Same problem here. The problem is that ./lib/howl/Posix/posix_interface.c includes /usr/include/linux/ethtool.h where we have struct with types __u8, __u16, __u32, __u64 but they are not typedefed in /lib/howl/Posix/posix_interface.c. And they should not. I think it's better to include linux/types.h. This is done in howl-0.9.8-types.patch! So I think the best way to fix this is to cp howl-0.9.8-types.patch into howl-0.9.6-types.patch and add necessary line in ebuild. Peter. howl-0.9.8 should me marked stable when any serious bugs open about it are fixexd. That will fix this also.. I think the problem more rightly lies in the latest linux-headers-2.6.8.1-r2 ebuild. I noticed that on one computer that I compiled linux-headers a while ago, the structs were defined in ethtool.h without the preceeding __, for example u32 instead of __u32, and that this was the only difference between the files. It seems that at somepoint somebody must have updated a patch that went into the 2.6.8.1-r2 ebuild, because both machines have the same version of linux-headers. When I copied ethtool.h from one machine to the other, howl compiled fine. So is this a linux-headers problem or a howl problem? [quote]So I think the best way to fix this is to cp howl-0.9.8-types.patch into howl-0.9.6-types.patch and add necessary line in ebuild.[/quote] This doesn't work, i get: Failed Patch: howl-0.9.6-types.patch ! ( /usr/portage/net-misc/howl/files/howl-9.6.0-types.patch ) I guess its because some lines in the patch are directly pointing to some howl-0.9.8 directory, or something like that (unfortunately i don't really understand the syntax). Would it be adequate to just change that "howl-0.9.8" to "howl-0.9.6-r2"? Created attachment 55572 [details]
diff output between ethtool.h for linux-headers-2.6.8.1-r2
diff between ethtool.h from January and ethtool.h from April for
linux-headers-2.6.8.1-r2.
The problem will be fixed by using howl 0.9.8, however this still seems to me like a patch for linux headers would be a better fix. What other ebuilds use the ethtool.h header? Do they encounter the same error? My confusion comes from the fact that there is no patch in portage for linux-headers that effects ethtool.h, so how is it that two installs of the same version can have two different files. The one I compiled somtime at the end of January, the other I compiled on monday, and the ethtool.h files are different. How does this happen without a patch or a new version? I've attached the output of diff between the files. Created attachment 56198 [details, diff]
fixes missed typedef-s
// Just a line in <linux/ethtool.h>
#include <linux/types.h>
What is the proper way of informing the maintainers of linux-header about this? howl-0.9.6-r2 compiles on AMD64 and does not reproduce this problem Portage 2.0.51.19 (default-linux/amd64/2005.0, gcc-3.4.3, glibc-2.3.4.20041102-r 1, 2.6.11-gentoo-r6 x86_64) ================================================================= System uname: 2.6.11-gentoo-r6 x86_64 AMD Athlon(tm) 64 Processor 3000+ Gentoo Base System version 1.4.16 Python: dev-lang/python-2.3.4-r1 [2.3.4 (#1, Apr 23 2005, 00:48:30) ] ccache version 2.3 [enabled] dev-lang/python: 2.3.4-r1 sys-devel/autoconf: 2.13, 2.59-r6 sys-devel/automake: 1.8.5-r3, 1.5, 1.7.9-r1, 1.6.3, 1.4_p6, 1.9.4 sys-devel/binutils: 2.15.92.0.2-r7 sys-devel/libtool: 1.5.14 virtual/os-headers: 2.6.8.1-r4 ACCEPT_KEYWORDS="amd64" AUTOCLEAN="yes" CFLAGS="-O2 -march=k8 -pipe -fomit-frame-pointer" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/X1 1/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -march=k8 -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox strict" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/Linux/ distributions/gentoo" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="amd64 X acpi alsa apache2 berkdb bitmap-fonts cdr crypt directfb dvd dvdr d vdread fam fbcon font-server fortran gif gnome gpm gtk hal howl ipv6 jp2 jpeg li rc lzw lzw-tiff mp3 mysql mythtv ncurses nls ntpl opengl oss pam perl png python readline samba sandbox ssl tcpd tiff truetype truetype-fonts type1-fonts usb us erlocales vcd xml2 xpm xrandr xv zlib" Unset: ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLA Y This purpose of this comment is to add the linux-headers devs so they can take a look at this. *** Bug 90229 has been marked as a duplicate of this bug. *** Headers fixed in CVS, please emerge sync and remerge linux-headers. Thanks; please reopen bug if issue persists. Maybe I'm missing something, but if a new patch was added then why wasn't a new ebuild created with a -r3 version, so people know that there's an update available? I did a sync but no new version of linux-headers showed up (I had already installed the -r2 version). If there had been a new version I could have installed that and not had to come read all the bug reports to find the answer. Thanks for fixing this, though! *** Bug 91712 has been marked as a duplicate of this bug. *** *** Bug 91775 has been marked as a duplicate of this bug. *** *** Bug 92188 has been marked as a duplicate of this bug. *** |