Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 87069

Summary: DEPEND syntax errors in all ffmpeg-2.4.9-p*.ebuilds
Product: Gentoo Linux Reporter: Brian Dolbec <dolsen>
Component: Current packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal CC: dolsen
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Brian Dolbec (RETIRED) gentoo-dev 2005-03-28 23:50:41 UTC
There are no spaces around all brackets:
I could not find any docs that specified a space must separate brackets from everything else, but I seem to recall that it is required.  All examples I found also had spaces before and after a bracket.

eg.
DEPEND="imlib? (media-libs/imlib2)
		truetype? (>=media-libs/freetype-2)
		sdl? (>=media-libs/libsdl-1.2.1)
		doc? (app-text/texi2html)
		encode? (media-sound/lame)
		oggvorbis? (media-libs/libvorbis
					media-libs/libogg)
		!alpha?( aac? (media-libs/faad2 media-libs/faac) )
		dvd? (media-libs/a52dec)
		xvid? (media-libs/xvid)
		"

Porthole's dependency code was crashing due to the missing spaces by not slpitting correctly.  !alpha?( aac? (media-libs/faad2 media-libs/faac) )
was splitting out "!alpha?(" rather than "!alpha" and then getting an index out of range error because the following chuncks were out of whack.


Fixing the ebuild with spaces fixed it.  Unless the lack of spaces is still correct syntax I will add code to report the ebuild as a syntax bug when that type of error is discovered.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-29 04:52:18 UTC
Brian, it would help us incredibly if we knew which package you're even talking about here.
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2005-03-29 06:26:56 UTC
Oops!   I missed that, sorry :( 

It is ffmpeg
Comment 3 Chris White (RETIRED) gentoo-dev 2005-03-29 23:59:24 UTC
Fixed in cvs.  Thanks for reporting and using Gentoo!