Summary: | libsdl-1.2.8-r1 undefined references with gcc-2.95 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matt Taylor <liverbugg> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | 1.2.8-gcc2-asm.patch |
Description
Matt Taylor
2005-03-24 00:45:55 UTC
Created attachment 54317 [details, diff] 1.2.8-gcc2-asm.patch from http://www.devolution.com/pipermail/sdl-cvs/2005-February/000767.html added to portage, thanks :) the logic to apply the old 1.2.8-gcc2-asm.patch only on gcc2 in the ebuild should be removed as its no longer needed and it is broken if they are both applied. * Applying libsdl-1.2.8-gcc2.patch.bz2 ... [ ok ] * Applying 1.2.8-keyrepeat.patch ... [ ok ] * Applying 1.2.8-linux26.patch ... [ ok ] * Applying 1.2.8-amd64-endian.patch ... [ ok ] * Applying 1.2.8-gcc2-asm.patch ... * Failed Patch: 1.2.8-gcc2-asm.patch ! * ( /mnt/portage/portage/media-libs/libsdl/files/1.2.8-gcc2-asm.patch ) * * Include in your bugreport the contents of: * * /mnt/portage/tmp/portage/libsdl-1.2.8-r1/temp/1.2.8-gcc2-asm.patch-31520.out !!! ERROR: media-libs/libsdl-1.2.8-r1 failed. !!! Function epatch, Line 402, Exitcode 0 !!! Failed Patch: 1.2.8-gcc2-asm.patch! whoops, i didnt notice because i have gcc-2 :) fixed in cvs, sorry about that This patch causes the compile of libsdl-1.2.8-r1 to fail when compiling with GCC 3.4.3. See this bug report: http://bugs.gentoo.org/show_bug.cgi?id=87077 There is a fix that involves disabling a compile flag, but that is a hack for a bad patch. This patch is flawed and needs fixing. I suggest disabling it for gcc versions greater than 3.4. Remove the volatiles added in the top section of the patch and it compiles with -fforce-addr on gcc-3.4.3 (bug 87077) and still works with gcc2. This patch is from upstream, and I don't know if they had a reason for adding volatile or not, or if they support using -fforce-addr. |