Bug 85071 - kde-misc/kooldock-0.3 works on amd64
Bug#: 85071 Product:  Gentoo Linux Version: unspecified Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: amd64@gentoo.org Reported By: gbug@mail.hoenig.cc
Component: Ebuilds
URL: 
Summary: kde-misc/kooldock-0.3 works on amd64
Keywords:  
Status Whiteboard: 
Opened: 2005-03-13 05:16 0000
Description:   Opened: 2005-03-13 05:16 0000
Please add "~amd64" to the KEYWORDS for kde-misc/kooldock-0.3

------- Comment #1 From Christian Hoenig 2005-03-13 05:16:57 0000 -------
Portage 2.0.51.19 (default-linux/amd64/2005.0, gcc-3.4.3,
glibc-2.3.4.20041102-r0, 2.6.11-gentoo-r3 x86_64)
=================================================================
System uname: 2.6.11-gentoo-r3 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Mar 10 2005,
19:22:04)]
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.6.10
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=athlon64 -ffast-math -funroll-all-loops -funit-at-a-time
-fpeel-loops -funswitch-loops -fomit-frame-pointer -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=athlon64 -ffast-math -funroll-all-loops -funit-at-a-time
-fpeel-loops -funswitch-loops -fomit-frame-pointer -pipe"
DISTDIR="/var/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/var/portage/packages"
PORTAGE_TMPDIR="/var/portage/tmp"
PORTDIR="/var/portage/tree"
PORTDIR_OVERLAY="/var/portage/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib acpi alsa amd64 apm arts artswrappersuid audiofile avi
bash-completion berkdb bitmap-fonts bonobo cdparanoia cdr chipcard crypt cups
dga doc fam flac font-server foomaticdb gd gif gtk gtk2 gtkhtml guile hbci
imagemagick imlib ipv6 jack java jp2 jpeg junit kde kdeenablefinal libwww lzw
lzw-tiff motif mp3 mpeg mysql ncurses nls nptl nptlonly oggvorbis opengl oscar
oss pam perl png python qt qtmt quicktime readline real sdl skey slang ssl
symlink tcpd tetex tiff truetype truetype-fonts type1-fonts usb userlocales
xinerama xml xml2 xmms xpm xrandr xv zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS

------- Comment #2 From Marcus D. Hanwell 2005-03-13 07:44:41 0000 -------
It segfaulted after only about 10 seconds for me I'm afraid. I am running KDE
3.4 rc1 though. As this is due out shortly, I would like to see a little more
successful testing. I am using xinerama across two screens too, but the site
claims support for this. It is however linking against 3.4 so I was unable to
test it in 3.3 properly.

------- Comment #3 From Marcus D. Hanwell 2005-03-13 08:25:58 0000 -------
After a little more experimentation it is the mouseout event that causes the
crash  for me. Can others reproduce this? The application restarts itself after
the crash - gets pretty irritating.

------- Comment #4 From Christian Hoenig 2005-03-13 09:08:52 0000 -------
I'm running KDE 3.4rc1, too. And I'm running xinerama, too :-). Though over 3 
monitors stretched (2 nvidia and 1 mga).

But I do not get any segfaults, hmmm.

take care, have fun
/christian

------- Comment #5 From Marcus D. Hanwell 2005-03-13 10:03:40 0000 -------
That is very strange. This is nvidia with binary driver no xorg-x11-6.8.2-r1,
far saner CFLAGS of -march=k8 -O2 -pipe, and a standard KDE 3.4 rc1
installation. I will check out my single head system at work tomorrow and see
if that has any issues with this application.

------- Comment #6 From Christian Hoenig 2005-03-17 13:45:26 0000 -------
So, any new infos? Would be nice to have other positive/negative reports. I
never had problems with it, not with x86 nor with amd64 now.

Hope we get it amd64 soon :-)

take care, have fun
/christian

------- Comment #7 From ketjow 2005-03-18 10:07:19 0000 -------
it works for me, too (amd64), but i get random segfaults. After the segfault
the application restarts, so it's not that bad :)

Please add ~amd64 - after all it works

------- Comment #8 From ketjow 2005-03-20 08:21:19 0000 -------
Marcus Hanwell  is right. The problem is in the mouseOut event, but only when
you leave kooldock by the left :) I mean - you keep your mouse moving to the
left and when you leave kooldock it crashes and restarts. can anybody confirm
this?

------- Comment #9 From Marcus D. Hanwell 2005-03-20 08:27:42 0000 -------
I won't add ~amd64 to the keywords of an application that is so obviously
broken. I can however confirm that it only happens when you exit by the left!
That is very strange. I would take a look myself but don't have time right now
- if you can patch it to fix this broken behaviour I would happily keyword it.

------- Comment #10 From Christian Hoenig 2005-03-20 10:08:46 0000 -------
Hehe, 
now I can reproduce the segfault, too. 

And only, if the text over the icons is _activated_. As I have had that off all the time, I didn't get a single segfault before.

Unfortunately I currently have no time to look at that , too. 

take care, have fun
/christian

------- Comment #11 From David Leaver 2005-03-29 18:20:03 0000 -------
Created an attachment (id=54803) [details]
Fixes the left exit crash

Fixes the Mouse exitting on left crash for me.
Was fun debugging this :)

------- Comment #12 From David Leaver 2005-03-29 18:23:31 0000 -------
(From update of attachment 54803 [details])
>--- kooldock/kooldock/kooldock.cpp	2004-08-11 19:36:00.000000000 +1200
>+++ kooldock/kooldock/kooldock.cpp	2005-03-30 14:15:49.000000000 +1200
>@@ -999,7 +999,7 @@
>       else
>       {
>          // the rest of the icons
>-         xosdw->move(x + (cur_cx[i] - iwSmall/2 + adjust + SPACE_W) - (xosdw->w/2), dh - h - xosdw->h);
>+         if ((int)i > 0) xosdw->move(x + (cur_cx[i] - iwSmall/2 + adjust + SPACE_W) - (xosdw->w/2), dh - h - xosdw->h);
>       }
>       if(xosd_st==0)
>       {

------- Comment #13 From Marcus D. Hanwell 2005-03-30 16:17:24 0000 -------
Tested out the patch and it works fine here - good work. Adding the kde-other
herd to CC, as I would like this patch applying so that I can mark this ~amd64.
David you should also send this fix upstream.

I can apply the patch and commit kde-misc/kooldock-0.3-r1 if kde-other herd do
not object.

------- Comment #14 From Carsten Lohrke 2005-03-30 16:28:56 0000 -------
Marcus: I think no one objects as long as the patch reaches upstream. ;)

Christian: Please remove -ffast-math from your compiler flags. It is unsafe, will cause errors and is therefore not supported.

------- Comment #15 From Marcus D. Hanwell 2005-03-31 14:58:08 0000 -------
Thanks Carsten - committed it now.

Thanks for the patch David - have you already sent this upstream? Committed as kde-misc/kooldock-0.3-r1, please let me know if you have sent this patch upstream. Thanks.

------- Comment #16 From Christian Hoenig 2005-03-31 22:20:05 0000 -------
> Christian: Please remove -ffast-math from your compiler flags. 
> It is unsafe, will cause errors and is therefore not supported.

Ah, thanks for the heads up. Actually I never looked at my cflags when upgrading to amd64, I just took some marked as working in the forums :-)

take care, have fun
/christian

------- Comment #17 From David Leaver 2005-04-01 20:08:06 0000 -------
Yep, i've sent it upstream.
One of the devs there said:
-----------------
Hi, I just commited this patch, but I tested it on my machine and It seems it
isn't solving the problem for me.
When leaving the dock from the left side, kooldock seems to crash, it stops
responding. I will take a further look on this.
-----------------

So it seems to fix it on AMD64, but kooldock is still a bit buggy.
Dave.