Bug 84497 - mupen64-riceplugin-5.1.0 "patch failed" due to operator precedence error in ebuild
Bug#: 84497 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: morfic@gentoo.org Reported By: jos.delbar@ugent.be
Component: Games
URL: 
Summary: mupen64-riceplugin-5.1.0 "patch failed" due to operator precedence error in ebuild
Keywords:  
Status Whiteboard: 
Opened: 2005-03-08 04:53 0000
Description:   Opened: 2005-03-08 04:53 0000
The following line in the src_unpack() function of the current ebuild:

        use gtk2 && epatch ${FILESDIR}/${PN}-gtk2.patch || die "patch failed"

should be modified to:

        use gtk2 && (epatch ${FILESDIR}/${PN}-gtk2.patch || die "patch failed")

Otherwise the ebuild will unconditionally die with "patch failed" when not compiling with the gtk2 USE flag.

Reproducible: Always
Steps to Reproduce:
1. USE="-gtk2" emerge mupen64-riceplugin
2.
3.

Actual Results:  
>>> emerge (1 of 1) games-emulation/mupen64-riceplugin-5.1.0 to / 
>>> md5 src_uri ;-) riceplugin.tar.bz2 
>>> Unpacking source... 
>>> Unpacking riceplugin.tar.bz2 
to /var/tmp/portage/mupen64-riceplugin-5.1.0/work 
 * Applying mupen64-riceplugin-makefile.patch ...                         
[ ok ] 
 
!!! ERROR: games-emulation/mupen64-riceplugin-5.1.0 failed. 
!!! Function src_unpack, Line 38, Exitcode 1 
!!! patch failed 
!!! If you need support, post the topmost build error, NOT this status 
message. 


Portage 2.0.51.19 (default-linux/x86/2004.3, gcc-3.4.3, 
glibc-2.3.4.20050125-r0, 2.6.11-gentoo-r2 i686) 
================================================================= 
System uname: 2.6.11-gentoo-r2 i686 Intel(R) Pentium(R) M processor 1500MHz 
Gentoo Base System version 1.6.9 
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Feb 21 2005, 11:58:46)] 
dev-lang/python:     2.3.5 
sys-devel/autoconf:  2.59-r6, 2.13 
sys-devel/automake:  1.9.5, 1.8.5-r3, 1.7.9-r1, 1.6.3, 1.5, 1.4_p6 
sys-devel/binutils:  2.15.92.0.2-r4 
sys-devel/libtool:   1.5.10-r5 
virtual/os-headers:  2.6.8.1-r2 
ACCEPT_KEYWORDS="x86 ~x86" 
AUTOCLEAN="yes" 
CFLAGS="-march=pentium-m -mfpmath=sse -O2 -pipe" 
CHOST="i686-pc-linux-gnu" 
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" 
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" 
CXXFLAGS="-march=pentium-m -mfpmath=sse -O2 -pipe" 
DISTDIR="/usr/portage/distfiles" 
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms" 
GENTOO_MIRRORS="ftp://ftp.gentoo.skynet.be/pub/gentoo 
ftp://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ 
ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ 
ftp://mirrors.sec.informatik.tu-darmstadt.de/gentoo/" 
LANG="en_US.ISO8859-1" 
MAKEOPTS="-j2" 
PKGDIR="/usr/portage/packages" 
PORTAGE_TMPDIR="/var/tmp" 
PORTDIR="/usr/portage" 
PORTDIR_OVERLAY="/usr/local/portage" 
SYNC="rsync://rsync.be.gentoo.org/gentoo-portage" 
USE="x86 4kstacks X acpi alsa arts avi berkdb bitmap-fonts cdparanoia cdr 
crypt cups curl dga dio directfb divx4linux dvd emboss encode f77 fam fbcon 
flac font-server foomaticdb fortran gdbm gif gpm imagemagick imlib ipv6 java 
jpeg jpeg2k junit kde ldap libg++ libwww mad mikmod mmx motif mp3 mpeg msn 
ncurses nls oggvorbis opengl pam pcmcia pdflib perl png pnp ppds python qt 
quicktime readline real samba sdl slang spellsse sse2 ssl svg svga tcltk tcpd 
theora tiff truetype truetype-fonts type1-fonts unicode usb userlocales wifi 
wmf xml2 xmms xv xvid zlib video_cards_i810 video_cards_i915" 
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS

------- Comment #1 From Chris Gianelloni (RETIRED) 2005-03-08 06:06:49 0000 -------
Actually, it should be:

if use gtk2; then
    epatch ${FILESDIR}/${PN}-gtk2.patch || die "patch failed"
fi

------- Comment #2 From Disenchanted (RETIRED) 2005-03-08 23:09:21 0000 -------
fixed in portage, allow one hour to sync

thank you for reporting this