Summary: | Kaffeine 0.4.3b compile error with kdelibs-3.4 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stephen Leaf <smileaf> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | 2004.3 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 94223 |
Description
Stephen Leaf
2005-03-03 20:06:52 UTC
I confirm that kaffeine-0.4.3b uses #includes in a sloppy way and breaks with kde-3.4. kaffeine-0.5 works well though. Maybe you can ask the author to push out a revision of the 0.4 series that works with kde-3.4? Otherwise we could just mark kaffeine-0.5 stable and forget about 0.4... If I had to use 0.5 I'd find another player. IMO 0.5 is a usability nightmare. > IMO 0.5 is a usability nightmare.
I tend to agree... that's why I proposed you to ask for a new revision of kaffeine-0.4.x ;)
We could do it ourself :) I've been researching on what change they made to fix my bug. later I might look into other improvements they've done and possibly include those in my version. sadly I doubt they'll make a revision. Personally, I don't think we are the right people to host and maintain a forked version of kaffeine. You could just send your patches to the author. True. Really I didn't want a forked version. just something that will compile. more or less when I said we could do it ourself I was thinking. if you hate it as well would you like to help? not can gentoo host and maintain this. ;) > Really I didn't want a forked version. just something that will compile.
Ah, Ok. A patch to make it compile will be gladly accepted.
Just got an ebuild to compile it!! sadly it's a hack instead of a true fix but it works :D Here is my ebuild mods src_unpack() { kde_src_unpack epatch ${FILESDIR}/${P}-SecurityTracker-1011936.patch epatch ${FILESDIR}/kaffeine-KDE-3.4.0-compile-and-depreciated-fix.patch } src_compile() { econf || die emake || perl ${FILESDIR}/revinclude.pl && make || die } When it dies.. run my perl script which will rearrange the #includes then continue the compile again :) http://smileaf.org/files/kaffeine-0.4.3b-r2.tar.bz2 I don't think that can be an acceptable strategy... 0.6 should fix everything It also re-features the minimal mode with M! (i'm very happy about it). Still I think we should wait for -r1 with the xorg problem fixed.. Anyway until 3.4 is stable I don't see need to mark 0.5 or 0.6 stables. 0.6 does bring back some important functionality. but it's still not near as functional 0.4.3b. 1 such function I'm thinking of is the ability to skip ahead and backwards using they left and right arrow keys. true this can be done using they mouse scroll however this is not very friendly IMHO. but I will agree that there is no need for 0.5 or 0.6 until kde 3.4 is marked stable. Until they do get all the functionality back in tho I'll keep it in my package.mask and continue to just use my "non-acceptable strategy" ebuild to build it :) I'm marking 0.6-r1 stable to allow kde 3.4.1 to be marked stable. |