Bug 83996 - media-video/sswf-1.7.1 builds on amd64
Bug#: 83996 Product:  Gentoo Linux Version: unspecified Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: amd64@gentoo.org Reported By: apolkosnik@yahoo.com
Component: Unspecified
URL: 
Summary: media-video/sswf-1.7.1 builds on amd64
Keywords:  TESTED
Status Whiteboard: 
Opened: 2005-03-03 13:34 0000
Description:   Opened: 2005-03-03 13:34 0000 
>>> media-video/sswf-1.7.1 merged.
Please add the ~amd64 keyword to ebuild

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
media-video/sswf-1.7.1

------- Comment #1 From Daniel Gryniewicz 2005-03-03 14:15:17 0000 ------- 
Well, it builds, and it runs, but it seems to hardloop for me.  I don't know
how long these things are *suppose* to take, but I gave up after 10 minutes of
it taking 99.7% of my cpu to try and build one of the samples (new-anim).  I
can't mark tested under these circumstances.

------- Comment #2 From Danny van Dyk (RETIRED) 2005-03-03 14:30:24 0000 ------- 
*** Bug 83998 has been marked as a duplicate of this bug. ***

------- Comment #3 From Danny van Dyk (RETIRED) 2005-03-03 14:36:01 0000 ------- 
Adam: what did you do to test this package?

------- Comment #4 From Adam Polkosnik 2005-03-04 00:57:59 0000 ------- 
Here are the fixed functions for 64-bit that go into 
src/lib/libsswf_tags.c++


long TagBase::SIBitSize(long value)
{
        long    cnt;

        if(value < 0) {
                // a special case
                value =~ value;
        }
        cnt = 1;
        while(value > 0) {
                cnt++;
                value=value/2;
        }
        return cnt;
}


long TagBase::UIBitSize(unsigned long value)
{
        long    cnt;

        cnt = 0;
        do {
            cnt++;
            value=value/2;
        } while(value > 0);
        return cnt;
}

------- Comment #5 From Adam Polkosnik 2005-03-04 00:59:34 0000 ------- 
...and the code has been forwarded upstream. the same fix applies to both 1.7.1
and 1.7.2.

------- Comment #6 From Adam Polkosnik 2005-03-04 14:35:25 0000 ------- 
Created an attachment (id=52683) [details]
patch for sswf-1.7.1 and 1.7.2

------- Comment #7 From Adam Polkosnik 2005-03-07 15:31:22 0000 ------- 
Above patch fixed the "hardloop", I've wrote it, I've tested (examples
worked)it on both 32 and 64 bit. I can provide ebuilds if necessary. Please let
me know.

------- Comment #8 From Adam Polkosnik 2005-03-13 09:49:49 0000 ------- 
Created an attachment (id=53351) [details]
this fixes a quirk in a struct

long on 64bit platform is 8 bytes, int is 4, however on 32bit it's long is 4
bytes as is int. This fixes the struct so that it is using the proper size on
64bit platform.

------- Comment #9 From Adam Polkosnik 2005-03-13 10:13:31 0000 ------- 
Created an attachment (id=53353) [details]
sswf-1.7.1-r1_ebuild.patch

Patch to the 1.7.1-r1 ebuild attached. Can somebody mark it ~amd64, now that
I've fixed it up, and forwarded the changes to the author?!

------- Comment #10 From Daniel Gryniewicz 2005-03-19 19:51:49 0000 ------- 
Created an attachment (id=53908) [details]
sswf-1.7.1-r1.ebuild

This works for me now.	Attached is the acutal ebuild I used for this.	I also
used the two patches from this thread, referenced in the ebuild.

------- Comment #11 From Simon Stelling (RETIRED) 2005-03-23 06:33:54 0000 ------- 
Thanks for the patches, they're in CVS now!