Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 836656

Summary: app-editors/vscode-1.66.0-r1 does not respect LDFLAGS
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Adel KARA SLIMANE <adel.ks>
Status: RESOLVED FIXED    
Severity: normal CC: arthurzam, esavier, esigra, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/24976
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2022-04-02 15:54:09 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/vscode-1.66.0 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2022-04-02 15:54:10 UTC
Created attachment 768521 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-04-08 06:49:26 UTC
ci has reproduced this issue with version 1.66.0-r1 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2022-04-10 18:08:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15ee49df3be6c7bd66e931263f3e61a293dbe31b

commit 15ee49df3be6c7bd66e931263f3e61a293dbe31b
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-04-07 20:13:48 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-04-10 18:08:26 +0000

    app-editors/vscode: version bump to 1.66.1
    
    Closes: https://bugs.gentoo.org/836656
    Closes: https://bugs.gentoo.org/836657
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscode/Manifest                                      | 6 +++---
 .../vscode/{vscode-1.66.0-r1.ebuild => vscode-1.66.1.ebuild}     | 9 +++++----
 2 files changed, 8 insertions(+), 7 deletions(-)