Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 828416

Summary: dev-util/maxcso-1.13.0 does not respect LDFLAGS
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: orbea <orbea>
Status: RESOLVED FIXED    
Severity: normal CC: orbea, proxy-maint, sam
Priority: Normal Keywords: PullRequest, UPSTREAM
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/23224
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 331933    
Attachments: build.log

Description Agostino Sarubbo gentoo-dev 2021-12-05 07:35:43 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/maxcso-1.13.0 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2021-12-05 07:35:45 UTC
Created attachment 757452 [details]
build.log

build log and emerge --info
Comment 2 orbea 2021-12-05 18:50:12 UTC
I'll take care of this with a PR upstream within the next few days.
Comment 4 Larry the Git Cow gentoo-dev 2021-12-09 01:10:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24faf6e7e362d24a6fe49c2d653007c21fb7f356

commit 24faf6e7e362d24a6fe49c2d653007c21fb7f356
Author:     orbea <orbea@riseup.net>
AuthorDate: 2021-12-08 14:19:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-09 01:10:00 +0000

    dev-util/maxcso: Add patch to support LDFLAGS
    
    Closes: https://bugs.gentoo.org/828416
    Upstream-PR: https://github.com/unknownbrackets/maxcso/pull/58
    Upstream commit: a97c03ef16bffe535a05d01d5ab856d40a70863b
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/23224
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/maxcso/files/maxcso-1.13.0-ldflags.patch | 26 +++++++++++++++++++++++
 dev-util/maxcso/maxcso-1.13.0.ebuild              |  2 ++
 2 files changed, 28 insertions(+)