Bug 81060

Summary:	net-im/skype icons installation cleanup
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo Net-im project <net-im>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch over current ebuild Right patch over current ebuild

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2005-02-06 18:41:01 UTC

Currently skype ebuild installs all the icons at the right place.. but use them in the wrong way: make_desktop_entry is called with a relative path, of the 48x48 icon, with extension.
It also install them in an ugly way creating directories and moving files around.

The attached patch applied over current ebuild installs the icons with insinto/newins calls, and then uses the generic skype iconname to be sure that icon themes could replace it with something custom.

HTH, Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-02-06 18:41:17 UTC

Created attachment 50592 [details, diff]
Patch over current ebuild

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-02-06 18:44:19 UTC

Created attachment 50593 [details, diff]
Right patch over current ebuild

Ok so I should remember that if I change something, I should redirect the patch
to file, not on stdout :)
This time it works :)

Comment 3 Gustavo Felisberto (RETIRED) gentoo-dev

2005-02-07 08:57:44 UTC

Ok, sending -r1 to cvs, mixed patch :) I actually like the for lop :)

Thanks for the desktop tip.