Bug 80401 - links 2.1pre17 released + typo
|
Bug#:
80401
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: seemant@gentoo.org
|
Reported By: legion@birra.it
|
|
Component: Ebuilds
|
|
|
URL:
http://atrey.karlin.mff.cuni.cz/~clock/twibright/links/download.html
|
|
Summary: links 2.1pre17 released + typo
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2005-02-01 16:09 0000
|
links 2.1pre16 released
and there is a typo in description: "links is a fast lightweight text tand graphic web-browser"
Reproducible: Always
Steps to Reproduce:
Alessandro,
There's the new links version, take a look a report?
:)
seems ok, but USE=unicode doesn't work:
the patch doesn't applies (and also needs to be renamed to pre17)
Hope this hit portage soon
:)
Ingo, I really prefer text files a attachments, to be honest.
Thanks :)
Actually, the patch fails, so I need to fix0r it up to work with pre17
Created an attachment (id=53901) [details]
links-2.1pre17-utf8.diff
I ported the current pre15 patch to pre17. It compiled and worked fine here
just renaming the current ebuild.
I would just like to call attention to terminal_options() in menu.c;
mem_alloc() was replaced with mem_calloc() and I'm not sure if just replacing
12 with 14 cuts it.
marcelo I have no idea -- but what exactly do you mean by "replacing 12 with 14
cuts it"? Where is the replacement, and what is it cutting?
Seemant, using this:
- d = mem_calloc(sizeof(struct dialog) + 12 * sizeof(struct dialog_item));
+ d = mem_calloc(sizeof(struct dialog) + 14 * sizeof(struct dialog_item));
instead of:
- if (!(d = mem_alloc(sizeof(struct dialog) + 12 * sizeof(struct dialog_item)))) return;
- memset(d, 0, sizeof(struct dialog) + 12 * sizeof(struct dialog_item));
+ if (!(d = mem_alloc(sizeof(struct dialog) + 14 * sizeof(struct dialog_item)))) return;
+ memset(d, 0, sizeof(struct dialog) + 14 * sizeof(struct dialog_item));
It's not actually "cutting" anything, that was just some poor slang for "works".
Marcelo, let's talk on irc, if you would. I'm online usually from 7am to 5pm
in the EST time zone. In the meantime, I've bzipped the patch and sent it to
our mirrors. Once it reaches those, I'll check in the version bump. Thanks for
your patience everyone
pre17 in portage with vanquirius as its new maintainer. Ingo, please file
future links bugs to him now. Thanks for all your help over the time I've been
looking after this package.
Hey Seemant,
We're here to help you, developers, to make Gentoo as great as it should be.
:)
Hey Seemant,
We're here to help you, developers, to make Gentoo as great as it should be.
:)
