Bug 787074

Summary:	[guru] games-action/blackvoxel-2.42 calls g++ directly
Product:	GURU	Reporter:	Agostino Sarubbo <ago>
Component:	Package issues	Assignee:	GURU project <guru-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	785607
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2021-04-30 09:36:19 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-action/blackvoxel-2.42 calls g++ directly.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different C++ implementation (like clang++). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].

Comment 1 Agostino Sarubbo gentoo-dev

2021-04-30 09:36:21 UTC

Created attachment 704175 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2021-04-30 09:36:23 UTC

Possible context of error(s):

/bin/sh: line 1: g++: command not found

Comment 3 Larry the Git Cow gentoo-dev

2021-05-03 10:11:09 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e2ea6e4b2f789206d798e4f909b21dc6d8c6dfa1

commit e2ea6e4b2f789206d798e4f909b21dc6d8c6dfa1
Author:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
AuthorDate: 2021-05-03 00:19:00 +0000
Commit:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
CommitDate: 2021-05-03 01:27:00 +0000

    games-action/blackvoxel: Remove hardcoded tools, set CXX, CC and AR.
    
    Changes proposed upstream:
    <https://github.com/Blackvoxel/Blackvoxel/pull/35>.
    
    Closes: https://bugs.gentoo.org/787074
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>

 games-action/blackvoxel/blackvoxel-2.42.ebuild     |   8 +-
 .../files/blackvoxel-2.42-makefile.patch           | 179 +++++++++++++++++++--
 2 files changed, 172 insertions(+), 15 deletions(-)

Comment 4 Samuel Bauer 2021-05-03 15:27:47 UTC

This seems to me like an upstream issue.

I already improved a bit the makefiles doing suggestions to the dev team in the past. I hope they can accept such pacth, as it allows user to choose his favorite compiler.