Bug 76535

Summary:	media-gfx/fbv should not link against X
Product:	Gentoo Linux	Reporter:	Philip Nilsson <leffeman>
Component:	New packages	Assignee:	Daniel Black (RETIRED) <dragonheart>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://s-tech.elsat.net.pl/fbv/
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to remove X linkage.

Description Philip Nilsson 2005-01-03 10:07:18 UTC

This ebuild links against X (-lX11), even though it uses no functions or even has anything to do with it. It builds without the linking. 1.0b has this fixed sort of (current version in portage is 0.99), they removed the link but kept the library path (-L/usr/X11R6/lib/). I've made a patch so I can build it myself, but upgrading to 1.0b might be a better version. I haven't tried it yet though, but I'd guess it would work without any changes to the ebuild.

Comment 1 Philip Nilsson 2005-01-03 10:08:27 UTC

Created attachment 47500 [details, diff]
Patch to remove X linkage.

Here's the patch.

Comment 2 Philip Nilsson 2005-01-03 13:44:08 UTC

OK, I've been investigating some, and it would only (maybe) be necessary to link with -lX11 is libungif is compiled with the X use flag. And I noticed that 1.0b actually commented out the LIBS line altogether. Hm, no they moved it to Make.conf, which didn't include -lX11 or the include when I ran configure. I wonder if it would work with 0.99 too, perhaps not, or perhaps it would work for people like me that use libungif without X. That might be the reason there is a LIBS line in the Makefile.

Yes, version 0.99 doesn't include -lX11 when I ran configure, but the Makefile has that evil line of course.

I'd rather suggest upgrading the ebuild to use fbv 1.0b instead.
1. It works for me.
2. I noticed that they fixed the buggy laggy thingy when scrolling large images.
3. I can't seem to go back in a sequence of images with backspace any more. (must be some of the new term-voodoo, can't see how it would have worked before, I can still use <> or ,.)
4. The documentation is for <=0.99.

Hm, just something interesting I found, ls can chdir to executables :|

Comment 3 Daniel Black (RETIRED) gentoo-dev

2005-01-03 14:23:56 UTC

did version bump.

If libungif is compiled with the X use flag then it should include X11 libraries itself rather than relying on programs that use it to know.

Thanks for the detailed submission.