Summary: | =dev-ruby/execjs-2.7.0: conditionally depend on dev-ruby/duktape-rb | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marek Szuba <marecki> |
Component: | Current packages | Assignee: | Gentoo Ruby Team <ruby> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=754942 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 754918 | ||
Bug Blocks: | 742893 |
Description
Marek Szuba
2020-11-16 13:46:57 UTC
I've opted to add a new revision for this to also update the EAPI. I have also listed duktape-rb as the first option. Since it is embedded there is a huge difference in running the test suite: 0.5s for duktape vs 9.5s for nodejs. I have some compatibility concerns for ES6/7 feature differences in duktape vs node in real-world scenarios but given the speed-up bonus I'd say that is a good trade-off. Note that going straight to stable is not possible since duktape-rb is not stable. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4ca787fbe41ec1e4489704931e1912f45194a68 commit c4ca787fbe41ec1e4489704931e1912f45194a68 Author: Hans de Graaff <graaff@gentoo.org> AuthorDate: 2020-11-21 08:52:49 +0000 Commit: Hans de Graaff <graaff@gentoo.org> CommitDate: 2020-11-21 08:52:49 +0000 dev-ruby/execjs: EAPI 7, add duktape-rb Closes: https://bugs.gentoo.org/754921 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Hans de Graaff <graaff@gentoo.org> dev-ruby/execjs/execjs-2.7.0-r1.ebuild | 35 ++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) Ah, duktape-rb is stable for ppc only. I have added a ppc stable keyword to the new execjs-2.7.0-r1, but I'd like to wait some time with other arches. I'm already seeing compatibility issues with this for projects at work. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=930e246410b9f585b6d6d54b57e9fe3fbbe5955d commit 930e246410b9f585b6d6d54b57e9fe3fbbe5955d Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2020-11-21 20:21:58 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2020-11-21 20:26:30 +0000 dev-ruby/execjs-2.7.0: drop ppc keyword The last net-libs/nodejs ebuild keyworded for ppc has just been removed due to security vulnerabilties, and it didn't actually compile on that arch anyway. Bug: https://bugs.gentoo.org/754921 Signed-off-by: Marek Szuba <marecki@gentoo.org> dev-ruby/execjs/execjs-2.7.0.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |