Bug 75174

Summary:	xorg 6.8.1 masked by keyword on ppc but it works fine (Exept a small problem in includes)
Product:	Gentoo Linux	Reporter:	Marcin Kurek <morgoth6>
Component:	Current packages	Assignee:	PPC Porters <ppc>
Status:	RESOLVED FIXED
Severity:	minor	CC:	x11
Priority:	High
Version:	unspecified
Hardware:	PPC
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	find /usr/src/linux/include -name memory.h

Description Marcin Kurek 2004-12-21 06:44:34 UTC

Today I emerged a recent xorg package prerelease (6.8.1) and it seems to work nice. I gues there is a good idea to make it ~ppc because many interesting changes for poc users (Mostly in Radeon drivers)

There is only one small problem when building it on ppc (And propably on some other archs) The file programs/Xserver/hw/xfree86/common/compiler.h include a asm/memory.h (line 1079) but this file is not present for ppc at all (I can see it's present for ppc64 for example) It seems it can be normaly removed (At last for ppc)

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1 Luca Barbato gentoo-dev

2004-12-21 09:34:22 UTC

Testing locally

Comment 2 Donnie Berkholz (RETIRED) gentoo-dev

2004-12-21 09:41:25 UTC

ajax, note asm/memory.h doesn't exist on ppc. Any clue to figure out which archs this is safe for?

Comment 3 Marcin Kurek 2004-12-21 15:25:09 UTC

As far as I can see this include it present only for arm and ppc64 architecture (This is funny because it's not present for x86 too and this package it ~x86 and I gues it's tested/developed on x86 machine)

Maybe this is a flaw of kernel 2.6.x header files ? I can't check for this include inside 2.4.x headers because I doesn't use them.

Comment 4 Donnie Berkholz (RETIRED) gentoo-dev

2004-12-21 16:30:17 UTC

Created attachment 46596 [details]
find /usr/src/linux/include -name memory.h

You are right. But it didn't die when I compiled, so I assumed things were
fine.

Comment 5 Marcin Kurek 2004-12-21 16:35:56 UTC

The compilation fails here with message about missing file when compiling the r128 dri driver.

Comment 6 Luca Barbato gentoo-dev

2004-12-22 05:22:52 UTC

Here the build break as should, which headers are you using?

Comment 7 Donnie Berkholz (RETIRED) gentoo-dev

2004-12-22 08:06:22 UTC

sys-kernel/linux26-headers-2.6.8.1-r1 (on x86)

Comment 8 Donnie Berkholz (RETIRED) gentoo-dev

2004-12-22 08:11:26 UTC

Ah, I see the problem. It's in a section activated by defined(__powerpc__), and it doesn't cut things down to ppc64 only.

Comment 9 Donnie Berkholz (RETIRED) gentoo-dev

2004-12-22 08:38:45 UTC

grep ^PATCH_VER /usr/portage/x11-base/xorg-x11/xorg-x11-6.8.1.901.ebuild

Make sure it's >=0.3.3.

Comment 10 Marcin Kurek 2004-12-22 09:49:38 UTC

I gues we need wait a bit (Still not in portage) But what about marking it as ~ppc ? I use it a few days without any problems.

Comment 11 Marcin Kurek 2004-12-25 14:05:38 UTC

  24 Dec 2004; David Holm <dholm@gentoo.org> xorg-x11-6.8.1.901.ebuild:
  Added to ~ppc.

  22 Dec 2004; Donnie Berkholz <spyderous@gentoo.org>;
  xorg-x11-6.8.1.901.ebuild:
  PATCH_VER 0.3.3. (#75174) 9370_all_6.7.0-ppc64-linux26-headers-v2.patch was
  in a generic PPC section when it needed to apply only for PPC64.