Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 744439

Summary: app-crypt/tpm2-pkcs11-1.4.0 uses -Werror for build
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Christopher Byrne <salah.coronya>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17653
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    

Description Agostino Sarubbo gentoo-dev 2020-09-24 06:07:04 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-crypt/tpm2-pkcs11-1.4.0 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2020-10-08 06:57:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd6af1944ccbf81a3d43df39ecc45e874493b87f

commit bd6af1944ccbf81a3d43df39ecc45e874493b87f
Author:     Salah Coronya <salah.coronya@gmail.com>
AuthorDate: 2020-09-24 18:40:32 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-10-08 06:46:44 +0000

    app-crypt/tpm2-pkcs11: Remove -WError, fix clang compile
    
    Closes: https://bugs.gentoo.org/744439
    Closes: https://bugs.gentoo.org/744457
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/17653
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../tpm2-pkcs11/files/tpm2-pkcs11-1.3.2-Remove-WError.patch | 12 ++++++++++++
 app-crypt/tpm2-pkcs11/tpm2-pkcs11-1.3.2.ebuild              | 13 ++++++++++++-
 app-crypt/tpm2-pkcs11/tpm2-pkcs11-1.4.0.ebuild              | 11 ++++++++++-
 3 files changed, 34 insertions(+), 2 deletions(-)