Bug 744313

Summary:	dev-python/subunit-1.4.0 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Python Gentoo Team <python>
Status:	RESOLVED FIXED
Severity:	normal	CC:	crabbedhaloablution, openstack
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/18644
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-09-23 10:08:31 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/subunit-1.4.0 uses -Werror for build.
Discovered on: ppc64 (internal ref: ppc64_at)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Larry the Git Cow gentoo-dev

2020-12-13 22:46:42 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d73470d3723db147f3ed35a3da90bf6903a3b49

commit 4d73470d3723db147f3ed35a3da90bf6903a3b49
Author:     Peter Alfredsen <crabbedhaloablution@icloud.com>
AuthorDate: 2020-12-13 21:57:41 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-12-13 22:38:38 +0000

    dev-python/subunit: remove -Werror from configure.ac
    
    Closes: https://bugs.gentoo.org/744313
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Peter Alfredsen <crabbedhaloablution@icloud.com>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/18644

 .../subunit/files/subunit-1.4.0-werror.patch       | 34 ++++++++++++++++++++++
 dev-python/subunit/subunit-1.4.0.ebuild            |  5 +++-
 2 files changed, 38 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f92e68f84de5ab7081731758d40c58f7effce9a

commit 5f92e68f84de5ab7081731758d40c58f7effce9a
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-12-13 22:44:18 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-12-13 22:44:40 +0000

    dev-python/subunit: call eautoreconf before multilib_copy_sources
    
    Also clean up the werror patch.
    
    Bug: https://bugs.gentoo.org/744313
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 dev-python/subunit/files/subunit-1.4.0-werror.patch | 6 +++---
 dev-python/subunit/subunit-1.4.0.ebuild             | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)