Summary: | Totem 0.9.22 compile failure: /usr/include/libintl.h: parse error before "const" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ed Catmur <ed> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | media-video, x11 |
Priority: | High | ||
Version: | 2004.3 | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://bugzilla.gnome.org/show_bug.cgi?id=159126 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | totem-0.99.22-x_includes.patch |
Description
Ed Catmur
2004-11-22 12:51:29 UTC
A gcc -E shows that on the offending lines in libintl.h gettext, etc. has been defined out of existence: # 1 "/usr/include/libintl.h" 1 3 4 # 35 "/usr/include/libintl.h" 3 4 (...) extern char *(__const char *__msgid) __attribute__ ((__nothrow__)); This can in turn be traced back to bonobo-i18n.h, which is defining out gettext etc. because ENABLE_NLS is not defined; this in turn is because the nls detection fails in configure. Will investigate with autotools. Looking at config.log: this is because LIBS is defined to '-L ' which of course breaks every AC test (i686-pc-linux-gnu-gcc: argument to `-L' is missing) This is because of configure.in line 203: LIBS="-L$x_libraries $LIBS" which breaks if $x_libraries is empty. Patching configure.in: --- configure.in 2004/11/22 21:41:20 1.1 +++ configure.in 2004/11/22 21:41:26 @@ -200,6 +200,9 @@ AC_SUBST(REMOTE_LIBS) AC_PATH_X CFLAGS="-I$x_includes $CFLAGS" +if test -z "$x_libraries" ; then + x_libraries="." +fi LIBS="-L$x_libraries $LIBS" XTEST_LIBS="" and running autoconf makes configure work as expected. I'll write a patching ebuild and test it the whole way. Ah, of course. I'm running xorg-x11-6.8.0-r2 (I know it's under development; I needed the threading fixes), which puts libXt.so in /usr/lib; so AC_PATH_X realises that linking X doesn't need any special -L flags and returns empty $x_libraries. I guess we should expect to see this sort of thing quite often till everything is fixed. I'll upstream this myself. Created attachment 44503 [details, diff] totem-0.99.22-x_includes.patch Yes, this works. Upstreamed at http://bugzilla.gnome.org/show_bug.cgi?id=159126 thanks for looking into and patching this this is a dupe of #71863, does that not work for you ? cc-ing x maintainers so they are aware of these kind of problems. No, the patch in bug 71863 was applied when the above build failure occurred. Perhaps because my gnome libraries are more up to date? Odd that I didn't realise they were the same bug, though. Anyway, my patch fixes the underlying problem, not just a symptom. patch applied to .19 & .22 , thanks for the works. |