Summary: | Using build 'kernel' and --minkernpackage causes genkernel to stop with an error | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | David Bryson (RETIRED) <mutex> |
Component: | genkernel | Assignee: | Gentoo Genkernel Maintainers <genkernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | patches bug in gen_cmdline.patch |
Description
David Bryson (RETIRED)
2004-11-05 14:22:05 UTC
Created attachment 43364 [details, diff]
patches bug in gen_cmdline.patch
This is patched from the genkernel_bradmssw folder in the gentoo cvs module as
of todays date.
It's really just a 1 line patch, nothing special.
The previous submitted patch does not actually fix this bug. It does provide a bit of clarity in regards to the state of BUILD_INITRD. However, I realized that the real problem from the bug is in this line: [ "${BUILD_INITRD}" -ne 0 ] && cp "${TEMP}/initrd-${KV}" "${TEMP}/minker npackage/initrd-${KV}" || gen_die 'Could not copy the initrd for the kernel pack age!' operational precedence says that '&&' and '||' have the same precedence level. The code was written like this: smt1 && stm2 || throw up and die It appears to me it was meant to work like this: stm1 && (stm2 || throw up and die) But when the code is executed it actually does the following: (stmt 1 && stm2) || throw up and die I propose parenthesis are added so that the code execution is: stm1 && (stm2 || throw up and die) Oh i see this is actually how the code is in cvs, so nevermind. Fixed in genkernel-3.1.0d; please reopen this bug if you have any problems. Thanks! |