Summary: | [PATCH] PORTAGE_BINHOST with custom FTP-port doesn't work | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Patrik Kullman <patrik> |
Component: | Binary packages support | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED OBSOLETE | ||
Severity: | major | CC: | koprut |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch for getbinpkg.patch to support port in HTTP/HTTPS/FTP |
Description
Patrik Kullman
2004-11-04 02:25:24 UTC
emerge info, and the PORTAGE_BINHOST string please (need to know how you specified it). Portage 2.0.51-r2 (default-linux/x86/2004.2, gcc-3.3.4, glibc-2.3.4.20040808-r1, 2.6.9-gentoo-paprik1 i686) ================================================================= System uname: 2.6.9-gentoo-paprik1 i686 Intel(R) Pentium(R) 4 CPU 2.00GHz Gentoo Base System version 1.4.16 distcc 2.16 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled] Autoconf: sys-devel/autoconf-2.59-r5 Automake: sys-devel/automake-1.8.5-r1 Binutils: sys-devel/binutils-2.14.90.0.8-r1 Headers: sys-kernel/linux26-headers-2.6.8.1 Libtools: sys-devel/libtool-1.5.2-r5 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CFLAGS="-O3 -march=pentium4 -fomit-frame-pointer -funroll-loops -pipe -mmmx -msse -msse2 -mfpmath=sse" CHOST="i686-pc-linux-gnu" COMPILER="" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3.3/share/config:/usr/kde/3.3/env:/usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-O3 -march=pentium4 -fomit-frame-pointer -funroll-loops -pipe -mmmx -msse -msse2 -mfpmath=sse" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs ccache distcc distlocks getbinpkg sandbox sfperms" GENTOO_MIRRORS="http://mirror.pudas.net/gentoo" MAKEOPTS="-j4" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="X aac aalib acpi alsa amd apache2 avi berkdb bindist bitmap-fonts bonobo cairo cddb cdr chroot clamav client crypt cups curl dga divx4linux dnd eds encode esd evo f77 faac faad fam ffmpeg flac flash foomaticdb freetype fs gb gd gdbm geoip gif gimp gimpprint gnome gnomedb gphoto2 gpm gstreamer gtk gtk2 gtkhtml guile hal icq imagemagick imap imlib imlib2 irmc jabber java javascript jp2 jpeg junit ldap libg++ libwww live mad matroska mdb mikmod mmx mmx2 mng mono motif mozcalendar mozilla moznocompose moznoirc moznomail mozp3p mozsvg mozxmlterm mpeg mpeg4 mplayer msn mysql mythtv nas ncurses net network nls ntlm nvidia oav offensive oggvorbis openal opengl operanom2 oscar oss pam passfile pdflib perl png pnp ppds python quicktime quotes readline rtc samba sasl sdl silc slang slp snmp speex spell sqlite sse sse2 ssl svg svga tetex theora tiff truetype type1 unicode usb v4l v4l2 vim-with-x virus-scan wmf wxwin wxwindows x86 xforms xml xml2 xosd xprint xv xvid xvmc zlib" PORTAGE_BINHOST="ftp://binpkg:binftp@digimyth.yes.nu:2121/pentium4" In getbinpkg.py, a port argument is never splitted out from "host" and never submitted to ftplib.. Ok I've patched my getbinpkg.py to support port, but when checking the source, I realized that ftp://binpkg:binftp@213.89.77.37*:2121/pentium4/All/ would be the proper way to specify PASV mode, though it only strips out the * after hostname when using ftplib, not when it calls wget.. will check if there's possible to tell wget not to use the * or if it has to be solved in another way. Created attachment 43277 [details, diff]
Patch for getbinpkg.patch to support port in HTTP/HTTPS/FTP
Self-explanatory patch
After going through the source more thoroughly, my suggestion is that a variable in /etc/make.conf should be read instead. Maybe a boolean FETCH_PASSIVE that affects both the standard FETCHCOMMAND and getbinpkg? looks like this bug was discovered long time ago. I just encountered the same problem. Is is going to be fixed in portage? my PORTAGE_BINHOST looks like PORTAGE_BINHOST="anonymous:pass@192.168.1.4:2121/" portage gives me this same error message as above. Zac: you know that code better, opinion on this one? (In reply to comment #4) > Created an attachment (id=43277) [edit] > Patch for getbinpkg.patch to support port in HTTP/HTTPS/FTP > > Self-explanatory patch The patch looks good enough to commit. (In reply to comment #5) > After going through the source more thoroughly, my suggestion is that a > variable in /etc/make.conf should be read instead. > > Maybe a boolean FETCH_PASSIVE that affects both the standard FETCHCOMMAND and > getbinpkg? > Is that directly related to this bug? Bug 167902 has been filed wrt failures with servers that don't allow PASV. I wonder why passive mode shouldn't always be default since it works nicely when the client is using network address translation (unlike active mode). (In reply to comment #8) time to push it in then ? :) *** Bug 267377 has been marked as a duplicate of this bug. *** The this patch is obsolete, since the affected code has been disabled since bug #438640 here: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d159be545ecb431addc3e7bb31a8ed8cfd9984af |