Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 68161

Summary: A suggestion for bash-completion: bash-completion-config
Product: Gentoo Linux Reporter: Joël <world.root>
Component: New packagesAssignee: Gentoo Shell Tools project <shell-tools>
Status: RESOLVED FIXED    
Severity: enhancement CC: m.debruijne, radek
Priority: Low    
Version: 2004.0   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---

Description Joël 2004-10-19 08:46:55 UTC
I have a small suggestion for bash-completion 20041017 and up..

Would it be a good idea to add a "bash-completion" USE flag to unrar, unace, cksfv etc, which would automatically create symlinks such as:

/etc/bash_completion.d/unrar -> /usr/share/bash-completion/unrar

.. upon emerge of unrar ?

Anyway, kind of a low-priority idea, but might be actually useful no? :-)
Comment 1 Ciaran McCreesh 2004-10-19 13:14:10 UTC
I still think bash-completion-config is the way to go. Not that I have any code for it, or anything like that...
Comment 2 Aaron Walker (RETIRED) gentoo-dev 2004-10-21 16:51:13 UTC
Turning this into the official bash-completion-config bug ;)
Comment 3 Ciaran McCreesh 2004-10-22 06:23:02 UTC
Ok, we need to be able to do this on a per-user basis as well as globally. I mean, if you've got several hundred lusers on a box, chances are not all of them use all of the same tools. So... We'd need a ~/.bash_completion.d/ for symlinks, presumably, with only global everyone gets it super common stuff going in /etc. For consistency we should probably install all the actual scripts into /usr, rather than a mixture of /etc and /usr like we do now.

As for ebuilds installing completion files... I suggest we do a teeeeeeny ickle eclass which provides a dobashcompletion function. Maybe we should also have a USE flag for it, in which case the eclass could (now that .51 is stable) do all the IUSE and use blah? stuff for us.
Comment 4 Aaron Walker (RETIRED) gentoo-dev 2004-10-29 15:10:24 UTC
app-shells/bash-completion-config-0.1 was just committed to CVS.  

*Please test*
Comment 5 Joël 2004-10-30 04:59:50 UTC
Nice work !  Thanks !!

A small quick with argument order though:

============================================================
joel ~ $ bash-completion-config  --uninstall --global povray
bash-completion-config-0.1

 * --global is not installed
 * Uninstalling povray ...                                                           [ ok ]
============================================================

Cheers,
joel
Comment 6 Joël 2004-10-30 05:04:09 UTC
I'd also suggest a switch to display all completion plugins (not just those that are currently installed) ?

Maybe -L --listall ?
Comment 7 Aaron Walker (RETIRED) gentoo-dev 2004-10-30 07:20:26 UTC
First of all, thanks very much for the feedback.  I've just committed 0.2 to cvs.  Fixed the --global quirk.  I've improved the list output somewhat (IMO), as well as implemented the optional 'all' argument.  This seemed like a better solution than offering a new -L --listall flag.  So use -l all or --list all.
Comment 8 Ciaran McCreesh 2004-10-30 18:14:05 UTC
I've found a few things that we should probably change regarding the autotools stuff and how we handle functions.sh. Too sleepy to fix them now though. Other than that looking good :)
Comment 9 Aaron Walker (RETIRED) gentoo-dev 2004-11-01 08:59:20 UTC
Just released 0.3.  The build goes as it should now.  make builds the files and make install installs them.  Also added a -nc, --nocolo(u)r flag and fixed the toggle flag 'quirks' the correct way (ie --global after install).  I think it's pretty much ready for general consumption and will probably close this bug in the next day or two.
Comment 10 Aaron Walker (RETIRED) gentoo-dev 2004-11-03 05:00:56 UTC
closing.