Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 666696

Summary: media-libs/opencolorio-1.1.0-r1 - .../work/opencolorio-1.1.0/src/pyglue/PyAllocationTransform.cpp:67:27: error: cast between incompatible function types from ‘PyObject* (*)(PyObject*)’ {aka ‘_object* (*)(_object*)’} to ‘PyCFunction’ {aka ‘_object* (*)(_ob
Product: Gentoo Linux Reporter: mael <mae.lippert>
Component: Current packagesAssignee: Gentoo Graphics Project <graphics+disabled>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, jstein, p.c-bugzilla, ted, waebbl-gentoo
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/12049
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867    
Attachments: build.log
"emerge --info" output
opencolorio-1.1.0-remove-Werror.patch

Description mael 2018-09-21 12:18:20 UTC
Created attachment 547486 [details]
build.log

opencolorio-1.1.0-r1 wont compile because i think somebody configured in the make file that warnings will be seen as errors...

build.log and "emerge --info" output will be provided...
Comment 1 mael 2018-09-21 12:19:15 UTC
Created attachment 547488 [details]
"emerge --info" output
Comment 2 Ted Marston 2018-12-11 14:54:53 UTC
I hit the same problem and was able to build it with gcc-7.3.0-r3 when
the following patch was applied:

--- opencolorio-1.1.0/src/apps/ociodisplay/main.cpp.Orig        2018-01-05 01:38:27.000000000 +0000
+++ opencolorio-1.1.0/src/apps/ociodisplay/main.cpp     2018-12-11 13:32:09.723329404 +0000
@@ -54,8 +54,8 @@
 #include <GL/glut.h>
 #else
 #include <GL/glew.h>
-#include <GL/gl.h>
-#include <GL/glext.h>
+/* #include <GL/gl.h> */
+/* #include <GL/glext.h> */
 #include <GL/glut.h>
 #endif

I havn't tried this with gcc-8 though.
Comment 3 Bernd Feige 2018-12-14 11:46:18 UTC
(In reply to Ted Marston from comment #2)
> I hit the same problem and was able to build it with gcc-7.3.0-r3 when
> the following patch was applied:

I believe if this is your fix, the original problem was probably https://bugs.gentoo.org/671486
Comment 4 Pablo Cholaky 2018-12-14 13:51:14 UTC
(In reply to Ted Marston from comment #2)
> I hit the same problem and was able to build it with gcc-7.3.0-r3 when
> the following patch was applied:
> 
> --- opencolorio-1.1.0/src/apps/ociodisplay/main.cpp.Orig        2018-01-05
> 01:38:27.000000000 +0000
> +++ opencolorio-1.1.0/src/apps/ociodisplay/main.cpp     2018-12-11
> 13:32:09.723329404 +0000
> @@ -54,8 +54,8 @@
>  #include <GL/glut.h>
>  #else
>  #include <GL/glew.h>
> -#include <GL/gl.h>
> -#include <GL/glext.h>
> +/* #include <GL/gl.h> */
> +/* #include <GL/glext.h> */
>  #include <GL/glut.h>
>  #endif
> 
> I havn't tried this with gcc-8 though.

I can confirm this patch working with GCC 8.2.0-r5
Comment 5 Ted Marston 2018-12-15 01:55:23 UTC
(In reply to Bernd Feige in comment #3)
> I believe if this is your fix, the original problem was probably
> https://bugs.gentoo.org/671486:

I've now applied that fix to media-libs/glew and still get the same
problems with opencolorio-1.1.0-r1, without adding my fix too.
Comment 6 Bernd 2019-05-18 11:17:57 UTC
I hit the same issue and IMO this is because of the -Werror flag in the pyglue CMakeLists.txt file.

The attached patch solves this issue for me.
Comment 7 Bernd 2019-05-18 11:19:21 UTC
Created attachment 577172 [details, diff]
opencolorio-1.1.0-remove-Werror.patch

Patch to remove -Werror from src/pyglue/CMakeLists.txt
Comment 8 Larry the Git Cow gentoo-dev 2019-05-19 17:54:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c90bb560b5723836ba466d41886e75fe832c1e9c

commit c90bb560b5723836ba466d41886e75fe832c1e9c
Author:     Bernd Waibel <waebbl@gmail.com>
AuthorDate: 2019-03-31 08:23:27 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-05-19 17:23:38 +0000

    media-libs/opencolorio: disable -Werror flag
    
    The src/pyglue/CMakeLists.txt has a global -Werror flag set
    for unix systems, which let the compile fail. This patch removes this
    flag.
    
    Closes: https://bugs.gentoo.org/666696
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Bernd Waibel <waebbl@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/12049
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/opencolorio-1.1.0-remove-Werror.patch         | 17 +++++++++++++++++
 media-libs/opencolorio/opencolorio-1.1.0-r1.ebuild      |  1 +
 2 files changed, 18 insertions(+)
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-06 22:54:38 UTC
*** Bug 660716 has been marked as a duplicate of this bug. ***