Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 666562

Summary: x11-plugins/pidgin-telegram-1.3.1 add libressl support
Product: Gentoo Linux Reporter: Stefan Strogin <steils>
Component: Current packagesAssignee: Conrad Kostecki <conikost>
Status: RESOLVED FIXED    
Severity: normal CC: jstein, proxy-maint
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/9915
https://github.com/majn/tgl/pull/26
https://github.com/gentoo/gentoo/pull/10384
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 561854    

Description Stefan Strogin gentoo-dev 2018-09-19 16:05:49 UTC
Need to add 'libressl' USE flag and an optional dependency on libressl instead of openssl.
Comment 1 Larry the Git Cow gentoo-dev 2018-09-28 10:05:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc7fa446c66da3e731c77c66eae051a9325e891a

commit bc7fa446c66da3e731c77c66eae051a9325e891a
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2018-09-19 16:12:02 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-09-28 10:05:03 +0000

    x11-plugins/pidgin-telegram: add USE libressl
    
    Closes: https://bugs.gentoo.org/666562
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/9915

 x11-plugins/pidgin-telegram/pidgin-telegram-1.3.1.ebuild | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 2 Stefan Strogin gentoo-dev 2018-11-10 07:34:27 UTC
Oops. The package builds successfully but doesn't work, at least with LibreSSL 2.6.5.

$ pidgin -d
...
(09:30:45) plugins: probing /usr/lib64/purple-2/telegram-purple.so
(09:30:45) plugins: /usr/lib64/purple-2/telegram-purple.so is not loadable: undefined symbol: RSA_get0_key
(09:30:45) prpl-telegram: tgprpl_init finished: This is 1.3.1+g065e0b7ac9 on libtgl 2.1.0
Comment 3 Larry the Git Cow gentoo-dev 2018-11-10 07:58:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53b3ef820d6e31261d1e530fbd0c9f50796d51d3

commit 53b3ef820d6e31261d1e530fbd0c9f50796d51d3
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-11-10 07:57:06 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-11-10 07:57:56 +0000

    x11-plugins/pidgin-telegram: Revert "add USE libressl"
    
    Bug: https://bugs.gentoo.org/666562
    Reverts: bc7fa446c66da3e731c77c66eae051a9325e891a
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 x11-plugins/pidgin-telegram/pidgin-telegram-1.3.1-r1.ebuild | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Comment 4 Stefan Strogin gentoo-dev 2018-11-10 08:40:18 UTC
Now it works, with this patch. And sent PR upstream.
Comment 5 Larry the Git Cow gentoo-dev 2018-11-22 21:30:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f2b4044d41090f465e12091ac2a1759e6240c3e

commit 7f2b4044d41090f465e12091ac2a1759e6240c3e
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2018-11-10 08:33:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-11-22 21:30:10 +0000

    x11-plugins/pidgin-telegram: add LibreSSL support
    
    Closes: https://bugs.gentoo.org/666562
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/10384
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../files/pidgin-telegram-1.3.1-libressl.patch     | 25 +++++++++++
 .../pidgin-telegram-1.3.1-r2.ebuild                | 49 ++++++++++++++++++++++
 2 files changed, 74 insertions(+)