Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 64608

Summary: freecol ebuild (new package)
Product: Gentoo Linux Reporter: lwillems <lars>
Component: New packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: enhancement CC: dju, flash3001
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
URL: http://freecol.sf.net
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: freecol-0.3.0.ebuild
freecol-0.3.0.ebuild
freecol-0.3.0.ebuild

Description lwillems 2004-09-19 02:39:38 UTC
Hi!

Attached is the freecol-0.3.0.ebuild
I would be very thankful if this ebuild could be added to portage.

FreeCol is a free clone of the classic strategy game Colonization. Colonization is a turn-based game similar to Civilization. The object is for the player to build an empire in America and to become independent of Europe.

It has been written entirely in Java and depends on the Java and Ant ebuilds. This ebuild is being submitted at this point in prepartion of the upcoming 0.3.0 release of FreeCol. games-strategy would be an excellent category for this ebuild.
I have never written an ebuild before so let me know if I can fix anything :-)

Cheers,
Lars

Reproducible: Always
Steps to Reproduce:
Comment 1 lwillems 2004-09-19 02:40:36 UTC
Created attachment 39902 [details]
freecol-0.3.0.ebuild
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2004-09-25 04:45:20 UTC
Comments:

Move the JAVA_HOME check to pkg_setup
Create the wrapper in src_unpack, not src_install
call cp once in src_install
set S to ${WORKDIR}/${PN} so you don't have to cd or refer to it
use mirror://sourceforge in SRC_URI
Comment 3 lwillems 2004-10-01 10:18:44 UTC
Created attachment 40881 [details]
freecol-0.3.0.ebuild

Made fixes as suggested at comment #2.
Comment 4 Alexandru Toma 2004-11-05 17:18:13 UTC
RDEPEND="|| (
    >=virtual/jdk-1.4
    >=virtual/jre-1.4 )"
is unneeded since all the jdk's provide a virtual/jre so just RDEPEND=">=virtual/jre-1.4" should be enough.
Comment 5 Alexandru Toma 2004-11-05 17:20:47 UTC
Also, there's no need for cd ${S} in src_compile() AFAIK.
Comment 6 lwillems 2004-11-06 02:14:36 UTC
About comment 4: how can a jre be enough? The FreeCol sourcecode is compiled during the ebuild so you would need a JDK to make it through the ebuild. Shouldn't it be:

RDEPEND=">=virtual/jdk-1.4"
Comment 7 Alexandru Toma 2004-11-06 02:43:06 UTC
> The FreeCol sourcecode is compiled during the ebuild so you would need a JDK to make it through the ebuild.

You're right... I missed the fact that you compile it... I thought it was binary only. In that case you should move the virtual/jdk to DEPEND and leave just the virtual/jre in RDEPEND... no sense on DEPEND-ing on the jdk.
Comment 8 lwillems 2004-12-08 09:43:56 UTC
Created attachment 45544 [details]
freecol-0.3.0.ebuild

The latest attachment should fix any remaining issues.

Note that the game will issue a warning that it can't load any music, but this
is normal because music will be added in the next release.
Comment 9 Mr. Bones. (RETIRED) gentoo-dev 2004-12-08 17:47:11 UTC
ok, since this comes with no docs to speak of, somebody clue me in on how this game is supposed to work.  Seems unplayable at this point.
Comment 10 Mr. Bones. (RETIRED) gentoo-dev 2004-12-09 00:30:31 UTC
games-strategy/freecol added to portage.  Thanks for the bug report and ebuild.