Bug 62809 - new version of app-laptop/tpb (v0.6.3)
Bug#: 62809 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: mobile@gentoo.org Reported By: eckert.thomas@gmx.net
Component: Ebuilds
URL: 
Summary: new version of app-laptop/tpb (v0.6.3)
Keywords:  
Status Whiteboard: 
Opened: 2004-09-04 04:06 0000
Description:   Opened: 2004-09-04 04:06 0000 
a new version of tpb is out -- it's running here for a few days without
problems.

The ebuild used is derived form this:
# $Header: /home/cvsroot/gentoo-x86/app-laptop/tpb^Atpb-0.6.0.ebuild,v 1.1
  2003/12/02 20:56:27 latexer Exp $
src_unpack() is not needed any more (including the patch)

(bug #53694 may be obsoleted by this)

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Seemant Kulleen (RETIRED) 2004-09-04 15:47:27 0000 ------- 
*** Bug 53694 has been marked as a duplicate of this bug. ***

------- Comment #2 From Colin Macdonald 2004-09-19 01:44:51 0000 ------- 
Works for me!

pkg_postinst says you need to have nvram support compiled into your kernel: however, this seems to be false: works fine for me as a module.  Suggest changing the to:

pkg_postinst() {
    einfo "tpb requires you to have nvram support compiled into"
    einfo "your kernel to function (or loaded as a module)."
}

------- Comment #3 From Henrik Brix Andersen 2004-09-19 02:14:03 0000 ------- 
Thank you for confirming this. I will change the pkg_postinst() message
accordingly and bump the package later today.

------- Comment #4 From Henrik Brix Andersen 2004-09-19 04:35:21 0000 ------- 
app-laptop/tpb-0.6.3 is now in portage. Closing this bug as FIXED.

Note: Patch for xosd issue in configure is still needed.

------- Comment #5 From Thomas Eckert 2004-09-19 07:15:36 0000 ------- 
thanks for adding to portage.

@comment #4: the xosd-configure-patch may have an other subtle problem; I double
checked right now: it's definitively not needed in my setup:
  x11-base/xfree-4.3.0-r6
  x11-libs/xosd-2.2.8-r1
(maybe a fancy USE-flag dependency?)

------- Comment #6 From Henrik Brix Andersen 2004-09-19 07:31:04 0000 ------- 
Please try 'USE="-xosd" emerge =app-laptop/tpb-0.6.3' and paste the output of
'ldd /usr/bin/tpb' here.

------- Comment #7 From Henrik Brix Andersen 2004-09-19 07:32:00 0000 ------- 
ahem.

Please try the above _without_ the mentioned patch.

------- Comment #8 From Thomas Eckert 2004-09-19 07:59:48 0000 ------- 
ebuild used:
--- snipp ---
# diff -u tpb-0.6.3.ebuild.org tpb-0.6.3.ebuild
--- tpb-0.6.3.ebuild.org        2004-09-19 13:32:25.000000000 +0200
+++ tpb-0.6.3.ebuild    2004-09-19 14:36:51.000000000 +0200
@@ -16,7 +16,7 @@
 DEPEND="X? ( virtual/x11 )
                xosd? ( >=x11-libs/xosd-2.2.0 )"
 
-src_unpack() {
+_off_src_unpack() {
        unpack ${A}
 
        cd ${S}
--- snapp ---

USE="-xosd" emerge tpb-0.6.3.ebuild
[ no errors reported ]

$ ldd /usr/bin/tpb
        libX11.so.6 => /usr/X11R6/lib/libX11.so.6 (0x40020000)
        libSM.so.6 => /usr/X11R6/lib/libSM.so.6 (0x400ff000)
        libICE.so.6 => /usr/X11R6/lib/libICE.so.6 (0x40108000)
        libc.so.6 => /lib/libc.so.6 (0x4011f000)
        libdl.so.2 => /lib/libdl.so.2 (0x40230000)
        /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
=> no osd-support of course, but buttons work fine ("ThinkPad" tested)

BUT NOW with USE="xosd" xosd is not linked in either.
I don't understand that any more as I checked my /var/db/pkg/app-laptop/tpb-0.6.3/tpb-0.6.3.ebuild before my last comment and
there was definitively no patch in it (maybe I forgot to restart the program).
Sorry for the false-alarm.

------- Comment #9 From Henrik Brix Andersen 2004-09-19 08:03:24 0000 ------- 
... which proves that the patch is still needed. Thank you for testing.

Re-closing as FIXED.