Summary: | [PATCH] --getbinpkg doesn't support $http_proxy | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Elan Ruusamäe <glen> |
Component: | Current packages | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | alcarvalho, matsuu |
Priority: | High | Keywords: | Inclusion |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 377365 | ||
Attachments: |
Patch for the version 2.0.51.22-r1, applied to lib/portage/pym/getbinpkg.py
The corrected proposed patch... |
Description
Elan Ruusamäe
2004-08-26 12:03:21 UTC
using portage-2.0.50-r10, PORTAGE_BINHOST="http://gentoo.XXX.TLD/HOSTNAME/" from /etc/make.conf Try this patch. http://zarquon.twobit.net/gentoo/portage/getbinpkg.py.diff (In reply to comment #2) > Try this patch. > > http://zarquon.twobit.net/gentoo/portage/getbinpkg.py.diff Did that patch actually work for anyone, is there someone who uses BINHOST who can test it? Created attachment 69378 [details, diff]
Patch for the version 2.0.51.22-r1, applied to lib/portage/pym/getbinpkg.py
This patch contains the code to make the http_proxy variable work, but it
doesn't get the value from make.conf, since this would be a much larger patch.
It also has a workaround for the strange squid behavior when making requests
with suffix range, as in Range: bytes=-3000, which is the most frequent case in
getbinpkg.py.
Squid randomly gets the whole file and sends to the client, sometimes, this
caused my first patch to crash with MemoryError when trying to get metadata
from large packages such as OpenOffice.
Patch looks good. One question though; what's the "Do not send user/password here" about? Created attachment 72451 [details, diff]
The corrected proposed patch...
The "Do not send password here" is for not sending the password as a URL. This
is because it goes in a header and encoded.
But it should be as this one I'm sending now, and not with the line that do
this commented out. :)
Now I think it's ok.
Is this fixed in the recent stable portage version? If so, this bug can be closed =) This looks like it may be a duplicate of bug 438640. Please re-open if it's still an issue. |