Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 617764

Summary: =net-misc/spice-gtk-0.33-r1: does not build with openssl 1.1
Product: Gentoo Linux Reporter: Hanno Böck <hanno>
Component: Current packagesAssignee: Virtualization Team <virtualization>
Status: RESOLVED FIXED    
Severity: normal CC: johannes.hirte, pacho
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 592438    
Attachments: spice-gtk-0.34-openssl-1.1.patch

Description Hanno Böck gentoo-dev 2017-05-07 19:18:16 UTC
Compile error:

spice-channel.c: In function ‘spice_channel_send_spice_ticket’:
spice-channel.c:1164:17: error: dereferencing pointer to incomplete type ‘EVP_PKEY {aka struct evp_pkey_st}’
     rsa = pubkey->pkey.rsa;
                 ^~
spice-channel.c: At top level:
spice-channel.c:2355:1: error: variable ‘spice_x509_mem_lookup’ has initializer but incomplete type
 static X509_LOOKUP_METHOD spice_x509_mem_lookup = {
 ^~~~~~
spice-channel.c:2356:5: warning: excess elements in struct initializer
     "spice_x509_mem_lookup",
     ^~~~~~~~~~~~~~~~~~~~~~~
spice-channel.c:2356:5: note: (near initialization for ‘spice_x509_mem_lookup’)
spice-channel.c:2357:5: warning: excess elements in struct initializer
     0
     ^
spice-channel.c:2357:5: note: (near initialization for ‘spice_x509_mem_lookup’)
spice-channel.c: In function ‘spice_channel_load_ca’:
spice-channel.c:2375:42: error: dereferencing pointer to incomplete type ‘SSL_CTX {aka struct ssl_ctx_st}’
     lookup = X509_STORE_add_lookup(c->ctx->cert_store, &spice_x509_mem_lookup);
                                          ^~
spice-channel.c:2389:43: error: dereferencing pointer to incomplete type ‘X509_LOOKUP {aka struct x509_lookup_st}’
                 X509_STORE_add_cert(lookup->store_ctx, itmp->x509);
                                           ^~
spice-channel.c: At top level:
spice-channel.c:2355:27: error: storage size of ‘spice_x509_mem_lookup’ isn’t known
 static X509_LOOKUP_METHOD spice_x509_mem_lookup = {
                           ^~~~~~~~~~~~~~~~~~~~~

Patches have been posted to upstream, but there was some discussion and they haven't been applied yet:
https://lists.freedesktop.org/archives/spice-devel/2016-December/034750.html
Comment 1 Matthias Maier gentoo-dev 2017-05-11 05:46:26 UTC
*** Bug 616236 has been marked as a duplicate of this bug. ***
Comment 2 Johannes Hirte 2018-03-04 12:21:06 UTC
Created attachment 522368 [details, diff]
spice-gtk-0.34-openssl-1.1.patch

simple patch for for getting spice-gtk build with openssl-1.1
Comment 3 Larry the Git Cow gentoo-dev 2018-03-19 15:31:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd6ee50aacb0fb9bd65ffd81e40e2266bf2b7b03

commit bd6ee50aacb0fb9bd65ffd81e40e2266bf2b7b03
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-03-19 15:29:37 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-03-19 15:29:37 +0000

    net-misc/spice-gtk: Apply openssl11/libressl patches
    
    Bug: https://bugs.gentoo.org/631250
    Bug: https://bugs.gentoo.org/617764
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 .../spice-gtk/files/spice-gtk-0.34-libressl.patch  |  43 ++++++
 .../spice-gtk/files/spice-gtk-0.34-openssl11.patch |  16 +++
 net-misc/spice-gtk/spice-gtk-0.34-r3.ebuild        | 153 +++++++++++++++++++++
 3 files changed, 212 insertions(+)}
Comment 4 Matthias Maier gentoo-dev 2018-03-19 15:32:40 UTC
Please test 0.34-r3 and close if that fixes the problem.