| Summary: | =app-admin/mcelog-148 fails to compile with /bin/sh linked to dash(-0.5.8.2) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Wilke Schwiedop <bugs> |
| Component: | Current packages | Assignee: | Matt Turner <mattst88> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bkohler, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 526268 | ||
| Attachments: |
Generated version.c file
mcelog-makefile-dash-fix.patch |
||
Created attachment 466978 [details, diff]
mcelog-makefile-dash-fix.patch
This patch should fix builds on dash, I've reported upstream but I'm not sure how they feel about other-shell-compat
Nice. Thanks for sending those upstream, Ben. Wow that was fast! v149 is out with this fix, FYI upstream fixed the *other* bashism too, so we need to drop "${FILESDIR}"/${PN}-1.0_pre3_p20120918-bashism.patch
Thanks Ben! I've pushed a bump to 149 and dropped the upstreamed patch. We should consider stabilizing 149 soon, since the latest stable doesn't support a bunch of modern hardware (like Skylake). |
Created attachment 466972 [details] Generated version.c file Looking at mcelogs Makefile the problem seems to be with the build rule for version.tmp I've attached the generated version.c, which obviously does not compile.