Summary: | portagemaster-0.1.8.ebuild (Update) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | milosn |
Component: | New packages | Assignee: | Karl Trygve Kalleberg (RETIRED) <karltk> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | milosn |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 4601 | ||
Bug Blocks: | |||
Attachments: |
portagemaster-0.1.8.ebuild (Update)
portagemaster-0.1.8-r1.ebuild (Update) |
Description
milosn
2002-08-06 19:13:24 UTC
Created attachment 2881 [details]
portagemaster-0.1.8.ebuild (Update)
"That is one solution, but for now I'd prefer to just make the affected packages dependent on Sun's jdk/jre. Bigger fish to fry in the Portage code at the moment. I'll leave this bug open as an enhancement request and get to it when I can get to it, which may not be soon. For now, just switch those guys over to depend on Sun's stuff." By D. Robbins in response to "virtual/jdk-1.4" issue thats what i did...why is this blocked again??? Milos I can't reproduce the "blocking" you are referring to, if you give me details, I can hopefully help. I've looked over the ebuild you submitted. We have made a good deal of changes to how our ebuilds work lately. I'm sorry we have not spent enough time evangelising our changes to our external contributors. The following is a list of issues I found. As you can see, all a minor hiccups: 1) It not pass lintool: * Testing for presence of env vars : failed - (E) Missing LICENSE= - (W) Missing SLOT= You must add LICENSE="GPL" or whatever license portagemaster is supplied under SLOT="0" KEYWORDS="x86" or whatever platform you _know_ it works on. If you haven't tested it on a particular platform, that platform should not go into the keywords. This holds true for Java apps as well. 2) The build is missing the # $Header:$ that's part of the header in skel.ebuild, please add it. 3) Packages should _not_ touch files inside /root. Why do you create /root/.${PN} ? 4) src_unpack(), as written in the build, is completely superflous; that is exactly what the default src_unpack does. Please remove it, to avoid excess bloat. If you fix these bugs, then upload a new a .ebuild (or a diff), _AND_ a ChangeLog with it, I'll commit it asap. Wrt to the virtual/jdk stuff, you can safely depend directly on dev-java/sun- jdk-1.4.x for now. Created attachment 2935 [details]
portagemaster-0.1.8-r1.ebuild (Update)
hmmm i think ive fixed everything except the "/root/.${PN}" directory. It is
created to store configuration file, and since portageMaster is intended to be
run by "root", I thought that's the place for it. If the directory is not there
user will be prompted to create it manualy.
I would like to leave it like this for now, and ill fix the portageMaster so
that "/root/portagemaster/" is not needed any more.
Milos
Yours and Robin Cull's submission were virtually identical. I rewrote his (random pick) and added it. Available as: app-admin/portagemaster-0.1.8. |