Bug 60712 - XOSD 2.2.8-r1's outline mode uses the wrong vertical offset (text is not centered on the outline).
Bug#: 60712 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: lanius@gentoo.org Reported By: skotlex@notsohotmail.com
Component: Applications
URL: 
Summary: XOSD 2.2.8-r1's outline mode uses the wrong vertical offset (text is not centered on the outline).
Keywords:  
Status Whiteboard: 
Opened: 2004-08-17 13:38 0000
Description:   Opened: 2004-08-17 13:38 0000
Last weekend up upgraded my system, and xosd got updated from 2.2.5-r1 to
2.2.8-r1, after this update, I noticed that the text displayed was "Wrong". I
played around with the xosd-xmms plugin, and realized that the shadow mode was
working, but the offset setting was "broken". The vertical offset math seems
broken in particular. For example, if I use an offset of one, the outlined
black text is two pixels higher/wider than the normal text, yet those two extra
pixels are drawn on the bottom of the text instead of one up and one below. If
I set an offset of two, now the four extra black outline horizontal lines are
all piled on the bottom of the text, in other words, both the text and the
outline are vertically aligned to the top, rather than centered.
Is this some weird problem that only I have bumped into? The On Screen Display
plugin I use on XMMS says it is version 2.2.8, and the problem exists there and
on osd_cat and pretty much on every xosd scripts/programs I have lying around.
Oh I tested it with the default font settings of osd_cat, and the personal font
settings I use on my apps
(-artwiz-aqui-medium-r-bold-*-11-*-*-*-p-*-iso8859-1), and this issue persists
independently of which area of the screen you tell the text to appear in.

Reproducible: Always
Steps to Reproduce:
1. Use osd_cat or the xmms xosd plugin to display some text with an offset of
at least 1 and a shadow of 0.
2. 
3.

Actual Results:  
Both text and outline were vertically aligned to the top of where the text
should be displayed.

Expected Results:  
Outlined text is where it should be, but the text should appear vertically
centered on it.

I run a "x86" keyworded system, and the main dependencies versions would be:

media-libs/gdk-pixbuf-0.22.0-r2
gnome-base/gnome-libs-1.4.2

Emerge info:

Portage 2.0.50-r9 (default-x86-2004.2, gcc-3.3.3, glibc-2.3.3.20040420-r1,
2.4.2

6-gentoo-r6)
=================================================================
System uname: 2.4.26-gentoo-r6 i686 AMD Athlon(tm) XP 2500+
Gentoo Base System version 1.4.16
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -finline-functions
-finl

ine-limit=600 -mfpmath=387 -ffast-math -ftracer -funroll-loops
-fprefetch-loop-a
                                                                         rrays
-freduce-all-givs"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/s

hare/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -finline-functions
-fi

nline-limit=600 -mfpmath=387 -ffast-math -ftracer -funroll-loops
-fprefetch-loop
                                                                        
-arrays
-freduce-all-givs"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache digest sandbox userpriv"
GENTOO_MIRRORS="ftp:///ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/
http://mirr

or.datapipe.net/gentoo http://gentoo.binarycompass.org
http://gentoo.seren.com/g
                                                                         entoo
http://gentoo.mirrored.ca/"
MAKEOPTS="-j2 -s"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/etc/portage/overlay"
SYNC="rsync://rsync.samerica.gentoo.org/gentoo-portage"
USE="3dnow X acpi acpi4linux alsa avi canna cap cjk crypt cscope cups dedicated
                                                                          dga
dillo divx4linux dvd erandom fam fbcon flac freewnn gd gif gimpprint ginac g   
                                                                      pm gtk
gtk2 imap imlib innodb jabber java jikes jpeg kerberos libwww matroska mb      
                                                                   ox mikmod
mmx
moznocompose moznoirc moznomail mpeg objc oggvorbis opengl pam par             
                                                            se-clocks pcre
pdflib perl png ppds python quicktime readline rtc samba scanner               
                                                           sdl spell sse ssl
tcltk theora threads tiff truetype unicode usagi usb vim-with-                 
                                                        x wmf x86 xface xml
xml2
xmms xv xvid zlib"

------- Comment #1 From Wallex 2004-08-17 13:44:02 0000 -------
Created an attachment (id=37627) [details]
(cropped) Screenshot of the issue.

That's the xosd xmms plugin text with a setting of offset 1 and shadow 0,
centered on the top of the screen with a vertical offset of 2 (such value does
not affects the bug, already tested)

------- Comment #2 From Heinrich Wendel (RETIRED) 2004-08-19 02:11:25 0000 -------
what happens if you comment the patch in the ebuild:

#epatch ${FILESDIR}/${PV}-xmms-trackpos.patch

------- Comment #3 From Wallex 2004-08-19 09:39:57 0000 -------
Nope... commenting out the patch did no difference. Apparently it is a bug in
xosd itself.
I hope more people can reproduce this bug, I'd hate to think I am the only lone
soul out there for whom XOsd's outline mode is broken...

------- Comment #4 From Duhovej_Vil 2004-08-27 00:45:00 0000 -------
Created an attachment (id=38276) [details]
Patch for correcting vertical positioning of outlined texts

This patch corrects the vertical positioning of outlined texts. I have already
contacted the author of xosd and sent him this patch.

------- Comment #5 From Heinrich Wendel (RETIRED) 2004-09-08 03:07:20 0000 -------
fixed in 2.2.10