Bug 60345 - Packages with bad patches
Bug#: 60345 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: normal Priority: P2
Resolution: LATER Assigned To: qa@gentoo.org Reported By: chriswhite@gentoo.org
Component: Ebuilds
URL: 
Summary: Packages with bad patches
Keywords:  
Status Whiteboard: 
Opened: 2004-08-14 09:47 0000
Description:   Opened: 2004-08-14 09:47 0000
Did a full repoman on the tree last night with the the epatch repoman
check mentioned in Bug #59902.  Results will be attached in just a second.
I'll try and sort this all into the appropriate herds once I do some much 
needed version bumping.

------- Comment #1 From Chris White (RETIRED) 2004-08-14 09:48:19 0000 -------
Created an attachment (id=37432) [details]
Output on repoman's check on bad patches

------- Comment #2 From Chris White (RETIRED) 2004-08-14 12:10:27 0000 -------
Adding cc's for relevant herds/maintainers, please check the attached file
for the packages listed under your email:

emacs@gentoo.org - emacs
liquidx@gentoo.org - poedit
openoffice@gentoo.org - openoffice
sci@gentoo.org - singular
usata@gentoo.org - zsh
text-markup@gentoo.org - tetex
pgsql-bug@gentoo.org - libpqpp
mysql-bugs@gentoo.org - mysql mysql++ (needs metadata.xml as well)
stkn@gentoo.org - pwlib
lisp@gentoo.org - cmucl/-source
perl@gentoo.org - libperl and mod_perl
python@gentoo.org - PyQT
games@gentoo.org - netris
kde@gentoo.org - kdebase
net-mail@gentoo.org - pine
g2boojum@gentoo.org - gnuplot
graphics@gentoo.org - xv (needs metadata.xml as well)
sound@gentoo.org - streamripper
media-tv@gentoo.org - xawtv
xfree@gentoo.org - nvidia-glx
mboman@gentoo.org - snort
net-dialup@gentoo.org - l2tpd and rp-l2tp
net-irc@gentoo.org - eggdrop
avenj@gentoo.org - netsed
solar@gentoo.org - middleman
web-apps@gentoo.org - mod_auth_external
base-system@gentoo.org - busybox
griffon26@gentoo.org - lwp
gnustep@gentoo.org - windowmaker

------- Comment #3 From SpanKY 2004-08-14 12:19:59 0000 -------
sounds like your patch needs work

netris is a false positive

------- Comment #4 From SpanKY 2004-08-14 12:20:27 0000 -------
as is streamripper

------- Comment #5 From Sven Wegener 2004-08-14 12:25:36 0000 -------
Removing net-irc as the epatch'es in net-irc/eggdrop are false positives.
The patch files are extracted and applied in src_unpack().

------- Comment #6 From solar 2004-08-14 12:29:25 0000 -------
I can't reproduce your problem on my local end with middleman. Are you sure
your checks are right?

------- Comment #7 From solar 2004-08-14 12:31:15 0000 -------
I think the same for busybox. I've merge this no less than 2-3 times a week

------- Comment #8 From Rob Cakebread 2004-08-14 12:33:09 0000 -------
Removed python@g.o., PyQt was a false positive, removed liquidx (I fixed
wxwindows herd epatch in poedit)

------- Comment #9 From Tuan Van (RETIRED) 2004-08-14 14:03:45 0000 -------
remove net-mail, pine fixed.

------- Comment #10 From Stefan Knoblich (RETIRED) 2004-08-14 14:16:31 0000 -------
pwlib fixed, thx

------- Comment #11 From Robin Johnson 2004-08-14 14:50:17 0000 -------
your patch needs work still.
Eg it complained at this, in mysql-4.0.15-r1:
[ "$PV" == "4.0.14" ] &&
epatch ${FILESDIR}/mysql-${PV}-security-28394.patch

Yes there is no line continuation, but it is still perfectly valid with any line continuation character.

MySQL++ is fixed.

------- Comment #12 From Andrew Bevitt 2004-08-14 15:13:29 0000 -------
Removing xfree nvidia-glx is false positive.

------- Comment #13 From SpanKY 2004-08-14 16:06:21 0000 -------
next time review the data before making maintainers waste their time ... theres
way too many false positives here for the scan to be useful i think