Bug 59832 - sg3_utils fails to compile with USE=pic
Bug#: 59832 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: major Priority: P2
Resolution: FIXED Assigned To: plasmaroo@gentoo.org Reported By: merlin@gentoo.org
Component: Ebuilds
URL: 
Summary: sg3_utils fails to compile with USE=pic
Keywords:  
Status Whiteboard: 
Opened: 2004-08-09 01:01 0000
Description:   Opened: 2004-08-09 01:01 0000 
sg3_utils uses llseek.c from util-linux. solar fixed util-linux's llseek.c with
files/util-linux-2.11z-pic.patch in July of 2003 (see the ChangeLog).

The _llseek() system call is actually the wrong way to call llseek now, and
while his patch does compile with -fPIC, I believe my implementation is better
(see Bug 51962).

With this change I believe we can compile safely with enhanced CFLAGS.

Finally, I removed the HAS_LONG_LONG check, since there is no configure script
that will ever define this, and the rest of the code uses long long liberally.

Attached is an ebuild and source code patch.

I will submit the source code patch upstream, too.

------- Comment #1 From Cory Visi (RETIRED) 2004-08-09 01:02:17 0000 ------- 
Created an attachment (id=37081) [details]
sg3_utils-llseek.patch

------- Comment #2 From Cory Visi (RETIRED) 2004-08-09 01:02:41 0000 ------- 
Created an attachment (id=37082) [details]
sg3_utils-1.06.ebuild.patch

------- Comment #3 From Tim Yamin (RETIRED) 2004-08-09 14:39:24 0000 ------- 
Now fixed in CVS, it should reach the rsync mirrors shortly - closing as FIXED.
Thanks for the patch and please reopen this bug if you have any further
issues...